From: Joel Becker <Joel.Becker@oracle.com>
To: Louis Rilling <Louis.Rilling@kerlabs.com>
Cc: linux-fsdevel@vger.kernel.org, cluster-devel@redhat.com,
ocfs2-devel@oss.oracle.com
Subject: Re: [Ocfs2-devel] [RFC] configfs: Pin configfs subsystems separately from new config_items.
Date: Fri, 20 Jun 2008 15:36:14 -0700 [thread overview]
Message-ID: <20080620223614.GD21416@mail.oracle.com> (raw)
In-Reply-To: <20080620124644.GQ30804@localhost>
On Fri, Jun 20, 2008 at 02:46:44PM +0200, Louis Rilling wrote:
> But keeping this last config_item_put() prevents the simplification that I'm
> defending. And I think that the simplification is worth moving this
> config_item_put() before client_drop_item().
I guess I'm not seeing what's simpler. Four lines of
try_module_get() aren't very complex, really. Conversely, having some
functions that *don't* do config_item_get_item() is weird. Not invalid,
just harder to read.
Let's put it on the shelf. What I have with this patch is
really no different in effective behavior.
Joel
--
"When ideas fail, words come in very handy."
- Goethe
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2008-06-20 22:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-17 22:41 [RFC] configfs: Pin configfs subsystems separately from new config_items Joel Becker
2008-06-18 12:31 ` [Ocfs2-devel] " Louis Rilling
2008-06-18 16:12 ` Joel Becker
2008-06-18 16:51 ` Louis Rilling
2008-06-18 20:07 ` Joel Becker
2008-06-19 11:13 ` [Ocfs2-devel] " Louis Rilling
2008-06-19 22:07 ` Joel Becker
2008-06-20 12:46 ` Louis Rilling
2008-06-20 22:36 ` Joel Becker [this message]
2008-06-23 15:44 ` Louis Rilling
2008-06-23 19:10 ` Joel Becker
2008-06-24 5:04 ` Louis Rilling
2008-06-24 17:03 ` Joel Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080620223614.GD21416@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=Louis.Rilling@kerlabs.com \
--cc=cluster-devel@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).