From: Andreas Gruenbacher <agruen@suse.de>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
John Johansen <jjohansen@suse.de>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [patch 3/3] vfs: make d_path() consistent across mount operations
Date: Mon, 23 Jun 2008 16:50:16 +0200 [thread overview]
Message-ID: <200806231650.16692.agruen@suse.de> (raw)
In-Reply-To: <20080623140144.GX28946@ZenIV.linux.org.uk>
On Monday 23 June 2008 16:01:44 Al Viro wrote:
> Umm... I don't see problems with doing that, but I hope you realize that
> the notion of "ever having that name" is not the same as "pathnam
> resolution on that name ever leading to that file" - path_walk() is *NOT*
> atomic wrt rename() (or mount --move, indeed) and it's quite possible to
> walk into subdirectory, have it moved under you, then see .. as the next
> pathname component and step out into new parent.
Yes, that's understood. Relative lookups don't visit all
directories up to the root (unless via ".."), so there can be
infinite time between walking down a directory and computing
a pathname for it.
> Said that, it makes sense to avoid dropping/regaining the lock in that
> case - it's less work and I don't believe that it would increase contention
> on vfsmount_lock. So I'm applying that one, just be careful with
> assumptions about consistency, etc. in the general area.
Thanks.
Andreas
prev parent reply other threads:[~2008-06-23 14:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-16 11:28 [patch 0/3] vfs: d_path cleanups and fixes Miklos Szeredi
2008-06-16 11:28 ` [patch 1/3] vfs: dcache cleanups Miklos Szeredi
2008-06-16 11:28 ` [patch 2/3] vfs: fix sys_getcwd for detached mounts Miklos Szeredi
2008-06-23 13:55 ` Al Viro
2008-06-23 14:34 ` Miklos Szeredi
2008-06-23 14:41 ` Al Viro
2008-06-16 11:28 ` [patch 3/3] vfs: make d_path() consistent across mount operations Miklos Szeredi
2008-06-23 14:01 ` Al Viro
2008-06-23 14:50 ` Andreas Gruenbacher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200806231650.16692.agruen@suse.de \
--to=agruen@suse.de \
--cc=hch@infradead.org \
--cc=jjohansen@suse.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).