From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Gruenbacher Subject: Re: [patch 3/3] vfs: make d_path() consistent across mount operations Date: Mon, 23 Jun 2008 16:50:16 +0200 Message-ID: <200806231650.16692.agruen@suse.de> References: <20080616112804.930095761@szeredi.hu> <20080616112830.003942737@szeredi.hu> <20080623140144.GX28946@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: Miklos Szeredi , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, John Johansen , Christoph Hellwig To: Al Viro Return-path: Received: from cantor.suse.de ([195.135.220.2]:56762 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757278AbYFWOuT (ORCPT ); Mon, 23 Jun 2008 10:50:19 -0400 In-Reply-To: <20080623140144.GX28946@ZenIV.linux.org.uk> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Monday 23 June 2008 16:01:44 Al Viro wrote: > Umm... I don't see problems with doing that, but I hope you realize that > the notion of "ever having that name" is not the same as "pathnam > resolution on that name ever leading to that file" - path_walk() is *NOT* > atomic wrt rename() (or mount --move, indeed) and it's quite possible to > walk into subdirectory, have it moved under you, then see .. as the next > pathname component and step out into new parent. Yes, that's understood. Relative lookups don't visit all directories up to the root (unless via ".."), so there can be infinite time between walking down a directory and computing a pathname for it. > Said that, it makes sense to avoid dropping/regaining the lock in that > case - it's less work and I don't believe that it would increase contention > on vfsmount_lock. So I'm applying that one, just be careful with > assumptions about consistency, etc. in the general area. Thanks. Andreas