From: Al Viro <viro@ZenIV.linux.org.uk>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
hch@infradead.org
Subject: Re: [patch v3] vfs: fix sys_getcwd for detached mounts
Date: Mon, 23 Jun 2008 19:50:43 +0100 [thread overview]
Message-ID: <20080623185043.GZ28946@ZenIV.linux.org.uk> (raw)
In-Reply-To: <E1KAqjG-00080e-KH@pomaz-ex.szeredi.hu>
On Mon, Jun 23, 2008 at 08:25:26PM +0200, Miklos Szeredi wrote:
> I tested this one in various situations, and it appears to do what
> it's supposed to.
>
> A somewhat analogous issue is if we have cwd (or fd) outside
> current->root. Should we add a prefix for that case as well? Perhaps
> a double slash?
OK, I've applied everything except the last one (all in for-linus in
vfs-2.6.git). As for the stuff outside current->root (or other namespace,
for that matter)... I don't like the idea of using // - as it is,
we have a nice sane check (path[0] != '/') and if anything, I'd consider
going for deleted:<path> instead of <path> (deleted) as we have now.
_That_ would eliminate the major annoyance with handling of unlinked/rmdired -
we'd get rid of guessing whether that's a file really called "a (deleted)"
or an unlinked one that used to be called "a"...
next prev parent reply other threads:[~2008-06-23 18:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-23 18:25 [patch v3] vfs: fix sys_getcwd for detached mounts Miklos Szeredi
2008-06-23 18:29 ` Matthew Wilcox
2008-06-23 18:50 ` Al Viro [this message]
2008-06-23 19:06 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080623185043.GZ28946@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox