From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [RESEND][PATCH -mm 1/2] vfs: fix coding style at dcache.c. Date: Mon, 23 Jun 2008 19:07:05 -0700 Message-ID: <20080623190705.04cedae2.akpm@linux-foundation.org> References: <486051AA.8000507@np.css.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, viro@ZenIV.linux.org.uk, harvey.harrison@gmail.com To: Kentaro Makita Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:34371 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751101AbYFXCHL (ORCPT ); Mon, 23 Jun 2008 22:07:11 -0400 In-Reply-To: <486051AA.8000507@np.css.fujitsu.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, 24 Jun 2008 10:45:14 +0900 Kentaro Makita wrote: > o fix coding style at dcache.c. No behavior changed. > > Signed-off-by: Kentaro Makita > --- > fs/dcache.c | 21 ++++++++++----------- > 1 files changed, 10 insertions(+), 11 deletions(-) > > Index: b/fs/dcache.c > =================================================================== > --- a/fs/dcache.c 2008-06-05 11:44:26.000000000 +0900 > +++ b/fs/dcache.c 2008-06-05 11:48:57.000000000 +0900 > @@ -453,15 +453,15 @@ static void __shrink_dcache_sb(struct su > int cnt = 0; > > BUG_ON(!sb); > - BUG_ON((flags & DCACHE_REFERENCED) && count == NULL); > + BUG_ON((flags & DCACHE_REFERENCED) && !count); A change like this isn't really a "fix". Both styles are acceptable and some people prefer the longer form.