* [RESEND][PATCH -mm 2/2] vfs: add cond_resched_lock while scanning dentry LRU lists
@ 2008-06-24 1:45 Kentaro Makita
2008-06-24 2:11 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Kentaro Makita @ 2008-06-24 1:45 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-fsdevel, akpm, viro, harvey.harrison
o add cond_resched_lock(&dcache_lock) while scanning LRU lists on superblocks
in __shrink_dcache_sb()
Signed-off-by: Kentaro Makita <k-makita@np.css.fujitsu.com>
---
fs/dcache.c | 1 +
1 files changed, 1 insertion(+)
Index: b/fs/dcache.c
===================================================================
--- a/fs/dcache.c 2008-06-05 11:48:57.000000000 +0900
+++ b/fs/dcache.c 2008-06-05 11:49:19.000000000 +0900
@@ -484,6 +484,7 @@ restart:
if (--cnt == 0)
break;
}
+ cond_resched_lock(&dcache_lock);
}
}
while (!list_empty(&tmp)) {
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [RESEND][PATCH -mm 2/2] vfs: add cond_resched_lock while scanning dentry LRU lists
2008-06-24 1:45 [RESEND][PATCH -mm 2/2] vfs: add cond_resched_lock while scanning dentry LRU lists Kentaro Makita
@ 2008-06-24 2:11 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2008-06-24 2:11 UTC (permalink / raw)
To: Kentaro Makita; +Cc: linux-kernel, linux-fsdevel, viro, harvey.harrison
On Tue, 24 Jun 2008 10:45:23 +0900 Kentaro Makita <k-makita@np.css.fujitsu.com> wrote:
> o add cond_resched_lock(&dcache_lock) while scanning LRU lists on superblocks
> in __shrink_dcache_sb()
>
> Signed-off-by: Kentaro Makita <k-makita@np.css.fujitsu.com>
> ---
> fs/dcache.c | 1 +
> 1 files changed, 1 insertion(+)
>
> Index: b/fs/dcache.c
> ===================================================================
> --- a/fs/dcache.c 2008-06-05 11:48:57.000000000 +0900
> +++ b/fs/dcache.c 2008-06-05 11:49:19.000000000 +0900
> @@ -484,6 +484,7 @@ restart:
> if (--cnt == 0)
> break;
> }
> + cond_resched_lock(&dcache_lock);
> }
> }
> while (!list_empty(&tmp)) {
The changelog is insufficient. It tells us what the patch did (which
was completely obvious anyway) but it fails to tell us _why_ the patch
did it.
That is is easily guessable but a good changelog would have described
the problem which you observed and would have described how the the
patch changed the runtime behaviour.
And this is not a trivial formality either. Because if, for example,
the problem whcih you are fixing here is "machine goes comatose for ten
minutes" then we'll need algorithmic changes and not a bandaid of this
nature.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-06-24 2:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-24 1:45 [RESEND][PATCH -mm 2/2] vfs: add cond_resched_lock while scanning dentry LRU lists Kentaro Makita
2008-06-24 2:11 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).