From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: "r/o bind mounts" patch in 2.6.26-rc6 changes (breaks?) error behaviour Date: Tue, 24 Jun 2008 20:21:33 +0200 Message-ID: <20080624182132.GH5642@ucw.cz> References: <485B8361.6010708@LiPPERTEmbedded.de> <1213971466.7512.17.camel@nimitz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jens Rottmann , Al Viro , linux-fsdevel , "linux-kernel@vger.kernel.org" To: Dave Hansen Return-path: Received: from gprs189-60.eurotel.cz ([160.218.189.60]:2567 "EHLO spitz.ucw.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756712AbYFZISk (ORCPT ); Thu, 26 Jun 2008 04:18:40 -0400 Content-Disposition: inline In-Reply-To: <1213971466.7512.17.camel@nimitz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri 2008-06-20 07:17:46, Dave Hansen wrote: > On Fri, 2008-06-20 at 12:16 +0200, Jens Rottmann wrote: > > > > I noticed the following change in the error behaviour when attempting > > to delete nonexisting files/dirs from R/O-mounted directories: > > > > Linux 2.6.25.7: > > rm /RO_mounted_path/nonexisting_file > > ==> "No such file or directory" > > > > Linux 2.6.26-rc6-git6: > > rm /RO_mounted_path/nonexisting_file > > ==> "Read-only file system" > > We looked at this way back in the beginning when I started to work on > the patches. It was decided that the error codes weren't horribly > important. We did have a case a bit ago where it really mattered, and > Al fixed that up. > > I know this changed behavior a bit, but userspace can surely work around > it with read-only operations (stat) when it is really important to get > the error to the user just right. I'd say userspace should not have to work around this. Interface change, in stable series, w/o deprecation period, new interface is worse than the old one... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html