From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] (resend) reuse xxx_fifo_fops for xxx_pipe_fops
Date: Tue, 1 Jul 2008 01:10:45 -0700
Message-ID: <20080701011045.f4490332.akpm@linux-foundation.org>
References: <200807011103.02974.vda.linux@googlemail.com>
	<20080701003255.493f54e0.akpm@linux-foundation.org>
	<200807011203.50632.vda.linux@googlemail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Al Viro <viro@zeniv.linux.org.uk>, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org
To: Denys Vlasenko <vda.linux@googlemail.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from smtp1.linux-foundation.org ([140.211.169.13]:41647 "EHLO
	smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1756701AbYGAIKt (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 1 Jul 2008 04:10:49 -0400
In-Reply-To: <200807011203.50632.vda.linux@googlemail.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, 1 Jul 2008 12:03:50 +0200 Denys Vlasenko <vda.linux@googlemail.com> wrote:

> I think since XXX_pipe_fops are only used in this file,
> just explaining this in the comment would be enough.

no, a comment is only needed when the code is unobvious.  Make
the code obvious and we don't need a comment.

As Christoph pointed out, open-coding shared_read_fops everywhere
might make sense too.  It'd make it harder to unshare them later
on, but that's pretty improbable.