From: Christoph Hellwig <hch@infradead.org>
To: Denys Vlasenko <vda.linux@googlemail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] (resend) reuse xxx_fifo_fops for xxx_pipe_fops
Date: Tue, 1 Jul 2008 03:31:42 -0400 [thread overview]
Message-ID: <20080701073142.GA30362@infradead.org> (raw)
In-Reply-To: <200807011103.02974.vda.linux@googlemail.com>
On Tue, Jul 01, 2008 at 11:03:02AM +0200, Denys Vlasenko wrote:
> Hi Andrew, Al,
>
> I posted this patch a few months ago, but it apparently
> fell thru cracks. Here we go again.
>
> I noticed that read/write/rdwr_pipe_fops are (1) const and
> (2) exactly identical to xxx_fifo_fops, which are also const.
>
> Attached patch #defines xxx_pipe_fops as aliases to xxx_fifo_fops.
> Size difference:
Why do you need the #defines? Just use the _fifo_ name directly.
next prev parent reply other threads:[~2008-07-01 7:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-01 9:03 [PATCH] (resend) reuse xxx_fifo_fops for xxx_pipe_fops Denys Vlasenko
2008-07-01 7:31 ` Christoph Hellwig [this message]
2008-07-01 7:32 ` Andrew Morton
2008-07-01 10:03 ` Denys Vlasenko
2008-07-01 8:10 ` Andrew Morton
2008-07-01 8:15 ` Christoph Hellwig
2008-07-01 12:11 ` Denys Vlasenko
2008-07-01 12:16 ` Denys Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080701073142.GA30362@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vda.linux@googlemail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).