From mboxrd@z Thu Jan 1 00:00:00 1970 From: yamamoto@valinux.co.jp (YAMAMOTO Takashi) Subject: Re: [PATCH] fix task dirty balancing Date: Thu, 3 Jul 2008 16:33:55 +0900 (JST) Message-ID: <20080703073355.DEC1D5A19@siro.lan> References: <1215030438.28676.20.camel@lappy.programming.kicks-ass.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, nickpiggin@yahoo.com.au To: a.p.zijlstra@chello.nl Return-path: Received: from fms-01.valinux.co.jp ([210.128.90.1]:45302 "EHLO mail.valinux.co.jp" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S937012AbYGCHd5 (ORCPT ); Thu, 3 Jul 2008 03:33:57 -0400 In-Reply-To: Your message of "Wed, 02 Jul 2008 22:27:18 +0200" <1215030438.28676.20.camel@lappy.programming.kicks-ass.net> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: hi, > On Wed, 2008-07-02 at 17:26 +0900, YAMAMOTO Takashi wrote: > > hi, > > > > task_dirty_inc doesn't seem to be called properly for > > filesystems which don't use set_page_dirty for write(2). > > eg. ext2 w/o nobh option. > > I'm thinking this is an ext2 bug. So I'd rather it'd just call > set_page_dirty() like a proper filesystem instead of doing things like > this. set_page_dirty marks all buffers in a page dirty. it isn't suitable for what mark_buffer_dirty is used for. YAMAMOTO Takashi > > And I certainly don't like exporting task_dirty_inc() - filesystems and > the like should not have to know about things like that. > > Of course I'm utterly ignorant of filesystems, hence lets include more > clue-full people. > > > YAMAMOTO Takashi > > > > > > Signed-off-by: YAMAMOTO Takashi > > --- > > > > commit e68f05bf56d0652c107bba1cff3f8491e41a2117 > > Author: YAMAMOTO Takashi > > Date: Wed Jul 2 16:17:33 2008 +0900 > > > > fix dirty balancing for tasks. > > > > call task_dirty_inc when dirtying a page with mark_buffer_dirty. > > > > diff --git a/fs/buffer.c b/fs/buffer.c > > index 4788a9e..2f1c7c6 100644 > > --- a/fs/buffer.c > > +++ b/fs/buffer.c > > @@ -1219,8 +1219,9 @@ void mark_buffer_dirty(struct buffer_head *bh) > > return; > > } > > > > - if (!test_set_buffer_dirty(bh)) > > - __set_page_dirty(bh->b_page, page_mapping(bh->b_page), 0); > > + if (!test_set_buffer_dirty(bh) && > > + __set_page_dirty(bh->b_page, page_mapping(bh->b_page), 0)) > > + task_dirty_inc(current); > > } > > > > /* > > diff --git a/include/linux/writeback.h b/include/linux/writeback.h > > index bd91987..61d0aec 100644 > > --- a/include/linux/writeback.h > > +++ b/include/linux/writeback.h > > @@ -95,6 +95,7 @@ int wakeup_pdflush(long nr_pages); > > void laptop_io_completion(void); > > void laptop_sync_completion(void); > > void throttle_vm_writeout(gfp_t gfp_mask); > > +void task_dirty_inc(struct task_struct *); > > > > /* These are exported to sysctl. */ > > extern int dirty_background_ratio; > > diff --git a/mm/page-writeback.c b/mm/page-writeback.c > > index 29b1d1e..4dc85d0 100644 > > --- a/mm/page-writeback.c > > +++ b/mm/page-writeback.c > > @@ -176,10 +176,11 @@ void bdi_writeout_inc(struct backing_dev_info *bdi) > > } > > EXPORT_SYMBOL_GPL(bdi_writeout_inc); > > > > -static inline void task_dirty_inc(struct task_struct *tsk) > > +void task_dirty_inc(struct task_struct *tsk) > > { > > prop_inc_single(&vm_dirties, &tsk->dirties); > > } > > +EXPORT_SYMBOL_GPL(task_dirty_inc); > > > > /* > > * Obtain an accurate fraction of the BDI's portion.