From: "Andries E. Brouwer" <Andries.Brouwer@cwi.nl>
To: Jean Delvare <khali@linux-fr.org>
Cc: Andries Brouwer <Andries.Brouwer@cwi.nl>, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] partitions: Prefer strlcpy() over snprintf()
Date: Thu, 10 Jul 2008 14:28:01 +0200 [thread overview]
Message-ID: <20080710122801.GD30891@mette> (raw)
In-Reply-To: <20080710133004.26c0b991@hyperion.delvare>
On Thu, Jul 10, 2008 at 01:30:04PM +0200, Jean Delvare wrote:
> Subject: partitions: Prefer strlcpy() over snprintf()
>
> strlcpy is faster than snprintf when you don't use the returned value.
> if (!part)
> - snprintf(buf, BDEVNAME_SIZE, "%s", hd->disk_name);
> + strlcpy(buf, hd->disk_name, BDEVNAME_SIZE);
> else if (isdigit(hd->disk_name[strlen(hd->disk_name)-1]))
> snprintf(buf, BDEVNAME_SIZE, "%sp%d", hd->disk_name, part);
> else
Yecch. There is a parallelism between the two cases
which makes the source nice and readable.
You want to destroy the parallelism for no gain.
Different functions, different parameter order. Ach.
next prev parent reply other threads:[~2008-07-10 12:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-10 11:30 [PATCH] partitions: Prefer strlcpy() over snprintf() Jean Delvare
2008-07-10 12:28 ` Andries E. Brouwer [this message]
2008-07-10 13:03 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080710122801.GD30891@mette \
--to=andries.brouwer@cwi.nl \
--cc=khali@linux-fr.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox