From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: [PATCH] partitions: Prefer strlcpy() over snprintf() Date: Thu, 10 Jul 2008 13:30:04 +0200 Message-ID: <20080710133004.26c0b991@hyperion.delvare> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org To: Andries Brouwer Return-path: Received: from zone0.gcu-squad.org ([212.85.147.21]:39033 "EHLO services.gcu-squad.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753712AbYGJLaO (ORCPT ); Thu, 10 Jul 2008 07:30:14 -0400 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Subject: partitions: Prefer strlcpy() over snprintf() strlcpy is faster than snprintf when you don't use the returned value. Signed-off-by: Jean Delvare Cc: Andries Brouwer --- This patch was already sent on: * 2008-05-09 fs/partitions/check.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-2.6.26-rc1.orig/fs/partitions/check.c 2008-05-09 17:35:37.000000000 +0200 +++ linux-2.6.26-rc1/fs/partitions/check.c 2008-05-09 17:39:13.000000000 +0200 @@ -123,7 +123,7 @@ static int (*check_part[])(struct parsed char *disk_name(struct gendisk *hd, int part, char *buf) { if (!part) - snprintf(buf, BDEVNAME_SIZE, "%s", hd->disk_name); + strlcpy(buf, hd->disk_name, BDEVNAME_SIZE); else if (isdigit(hd->disk_name[strlen(hd->disk_name)-1])) snprintf(buf, BDEVNAME_SIZE, "%sp%d", hd->disk_name, part); else -- Jean Delvare