From: Al Viro <viro@ZenIV.linux.org.uk>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
akpm@linux-foundation.org
Subject: Re: [patch 2/2] Remove a few inlines in fs/namei.c
Date: Tue, 29 Jul 2008 19:55:37 +0100 [thread overview]
Message-ID: <20080729185537.GI28946@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20080729155527.799486507@free-electrons.com>
On Tue, Jul 29, 2008 at 05:52:31PM +0200, Thomas Petazzoni wrote:
> Uninline may_create() and do_follow_link() and use vfs_follow_link()
> instead of __vfs_follow_link() in __do_follow_link(). It allows to
> slightly reduce the size of kernel code:
>
> text data bss dec hex filename
> 1114299 118564 212992 1445855 160fdf vmlinux.old
> 1112971 118564 212992 1444527 160aaf vmlinux
> -1328 0 0 -1328 -530 +/-
>
> This patch is part of the Linux Tiny project and has been originally
> written by Matt Mackall <mpm@selenic.com>
Absolutely not. do_follow_link() et.al. are parts of mutual recursion
loop and we need to reduce the use of kernel *stack*.
next parent reply other threads:[~2008-07-29 18:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080729155229.489904417@free-electrons.com>
[not found] ` <20080729155527.799486507@free-electrons.com>
2008-07-29 18:55 ` Al Viro [this message]
2008-07-29 19:33 ` [patch 2/2] Remove a few inlines in fs/namei.c Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080729185537.GI28946@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).