From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [patch 15/19] Filesystem: XFS slab defragmentation Date: Tue, 12 Aug 2008 10:20:57 +1000 Message-ID: <20080812002057.GH6119@disturbed> References: <20080811150616.207532384@quilx.com> <20080811150659.051842926@quilx.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Pekka Enberg , akpm@linux-foundation.org, Christoph Lameter , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Mel Gorman , andi@firstfloor.org, Rik van Riel , mpm@selenic.com To: Christoph Lameter Return-path: Received: from ipmail05.adl2.internode.on.net ([203.16.214.145]:19534 "EHLO ipmail05.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751283AbYHLA0G (ORCPT ); Mon, 11 Aug 2008 20:26:06 -0400 Content-Disposition: inline In-Reply-To: <20080811150659.051842926@quilx.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Aug 11, 2008 at 08:06:31AM -0700, Christoph Lameter wrote: > Support inode defragmentation for xfs > > Reviewed-by: Rik van Riel > Signed-off-by: Christoph Lameter > Signed-off-by: Christoph Lameter > > --- > fs/xfs/linux-2.6/xfs_super.c | 1 + > 1 file changed, 1 insertion(+) > > Index: linux-next/fs/xfs/linux-2.6/xfs_super.c > =================================================================== > --- linux-next.orig/fs/xfs/linux-2.6/xfs_super.c 2008-08-11 07:42:11.892359719 -0700 > +++ linux-next/fs/xfs/linux-2.6/xfs_super.c 2008-08-11 07:47:05.072348463 -0700 > @@ -1947,6 +1947,7 @@ xfs_init_zones(void) > xfs_ioend_zone = kmem_zone_init(sizeof(xfs_ioend_t), "xfs_ioend"); > if (!xfs_ioend_zone) > goto out_destroy_vnode_zone; > + kmem_cache_setup_defrag(xfs_vnode_zone, get_inodes, kick_inodes); > > xfs_ioend_pool = mempool_create_slab_pool(4 * MAX_BUF_PER_PAGE, > xfs_ioend_zone); Please update this patch as per my last comment. Cheers, Dave. -- Dave Chinner david@fromorbit.com