From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@lst.de>
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/4] generic support for 64bit inodes in NFS filehandles
Date: Tue, 12 Aug 2008 18:31:54 +1000 [thread overview]
Message-ID: <20080812083154.GQ6119@disturbed> (raw)
In-Reply-To: <20080811134848.GC21264@lst.de>
On Mon, Aug 11, 2008 at 03:48:48PM +0200, Christoph Hellwig wrote:
> Move XFS's support for 64bit inodes in NFS filehandles to libfs. In
> detail:
>
> - add the FILEID_INO64_FLAG and thei64 case in struct fid to
> exportfs.h
> - deal with the 64bit inode cases in generic_fh_to_dentry and
> generic_fh_to_parent by adding them to the switch case table
> and rewriting the min filehandle size checks based on a readable
> helper
> - move export_encode_fh to libfs as generic_encode_fh32 and rewrite
> it to be a similar style as the other exportfs functions in libfs
> - add a new generic_encode_fh64 which is identical to
> generic_encode_fh32 except for dealing with 64bit inode filehandles
>
> XFS is switched over to the new code, switching over other filesystems
> like ext4 is left to their maintainers but should be rather trivial by
> looking at fs/xfs/linux-2.6/xfs_export.c
The XFS->generic conversion looks OK to me....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2008-08-12 8:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-11 13:48 [PATCH 1/4] generic support for 64bit inodes in NFS filehandles Christoph Hellwig
2008-08-12 8:31 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080812083154.GQ6119@disturbed \
--to=david@fromorbit.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).