From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH 0/7] Discard requests, v2 Date: Wed, 13 Aug 2008 13:15:47 +0200 Message-ID: <20080813111547.GZ20055@kernel.dk> References: <1218299181.26926.88.camel@pmac.infradead.org> <20080812091446.GF20055@kernel.dk> <1218535205.2977.131.camel@pmac.infradead.org> <20080812105428.GG20055@kernel.dk> <1218539797.2977.147.camel@pmac.infradead.org> <1218543544.2977.158.camel@pmac.infradead.org> <20080812125315.GH20055@kernel.dk> <1218546257.2977.167.camel@pmac.infradead.org> <1218556054.2977.188.camel@pmac.infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andrew Morton , Ric Wheeler , linux-fsdevel@vger.kernel.org, gilad@codefidence.com, matthew@wil.cx To: David Woodhouse Return-path: Received: from brick.kernel.dk ([87.55.233.238]:17281 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751934AbYHMLPu (ORCPT ); Wed, 13 Aug 2008 07:15:50 -0400 Content-Disposition: inline In-Reply-To: <1218556054.2977.188.camel@pmac.infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Aug 12 2008, David Woodhouse wrote: > On Tue, 2008-08-12 at 14:04 +0100, David Woodhouse wrote: > > > Or just match the check before -EOPNOTSUPP with bio_has_data(), > > > since it only applies to a barrier that carries data. > > > > Like this, you mean? Empty barriers don't get to there? > > Seems to work, although I'm somewhat dubious about it. Still, if you're > happy that it's correct and you really prefer it that way, then I can > commit it. Looks ok to me. > Anything else I need to address before you pull the tree? Any comment on > the BLKDISCARD ioctl? I've left that one using the non-barrier version > since it's waiting for it anyway, and shouldn't be happening > concurrently with anything else. > > (http://,git://} git.infradead.org/users/dwmw2/discard-2.6.git I'm with Jamie on using the safer version for the ioctl, unless you ensure that the block device isn't mounted before allowing it. -- Jens Axboe