From: Andrew Morton <akpm@linux-foundation.org>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: viro@ZenIV.linux.org.uk, djohnson@sw.starentnetworks.com,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
stable@kernel.org
Subject: Re: cramfs and named-pipe
Date: Fri, 15 Aug 2008 15:52:20 -0700 [thread overview]
Message-ID: <20080815155220.91ec8201.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080805.120909.139657748.nemoto@toshiba-tops.co.jp>
On Tue, 05 Aug 2008 12:09:09 +0900 (JST)
Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
> On Mon, 4 Aug 2008 11:03:47 +0100, Al Viro <viro@ZenIV.linux.org.uk> wrote:
> > Eeek... I'd rather not play these games with directories and devices nodes
> > as well. Rationale for the original patch simply doesn't apply for those.
> >
> > IOW, I think it would be much saner if we did the following: make ..._test()
> > refuse to merge inodes with ->i_ino == 1, take inode setup back to
> > get_cramfs_inode() and make ->drop_inode() evict ones with ->i_ino == 1
> > immediately. Comments?
> >
> > Patch below is completely untested; it builds, but that's it.
>
> Thanks, your patch works well for me. But it looks a bit large for
> stable tree (100 line rule).
>
> With current code, I think no problem on empty directories and device
> nodes. So how about fixing only FIFO case first (and send it to
> stable tree) and then go to your patch?
>
Nothing seems to have happened. Al, do you think your (now tested) patch
is good for 2.6.27 and 2.6.26.x? And, it seems, 2.6.25.x. (All the way
down to 2.6.14.x!)
next prev parent reply other threads:[~2008-08-15 22:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-04 9:21 cramfs and named-pipe Atsushi Nemoto
2008-08-04 10:03 ` Al Viro
2008-08-05 3:09 ` Atsushi Nemoto
2008-08-15 22:52 ` Andrew Morton [this message]
2008-08-20 20:18 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080815155220.91ec8201.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=anemo@mba.ocn.ne.jp \
--cc=djohnson@sw.starentnetworks.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).