linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pierre Ossman <drzeus-list@drzeus.cx>
To: linux-fsdevel@vger.kernel.org
Cc: David Woodhouse <dwmw2@infradead.org>, Jens Axboe <axboe@kernel.dk>
Subject: [PATCH 0/2] MMC discard support (was [PATCH 0/7] Discard requests, v2)
Date: Sat, 16 Aug 2008 19:08:58 +0200	[thread overview]
Message-ID: <20080816190858.4d150ea1@mjolnir.drzeus.cx> (raw)
In-Reply-To: <1218299181.26926.88.camel@pmac.infradead.org>

[-- Attachment #1: Type: text/plain, Size: 1198 bytes --]

I've cooked up some patches that maps David's new discard requests to
erase operations on MMC and SD cards. I'm not entirely sure these are
something to keep though as I've been unable to see any performance
increase in keeping blocks erased. Do we have any other reason to keep
it?

During development and test I noticed one issue though; the discard
requests are chopped up into smaller pieces. As the erase commands have
a granularity, sometimes this can mean that parts of the flash are
missed because the discard request isn't split in alignment with the
erase boundaries.

For this reason, I propose that discard requests do not respect the
regular queue restrictions. Those are generally for expressing
limitations in the devices' DMA engines. Since the discard request
carries no data, the DMA engine will never get involved.

-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  rdesktop, core developer          http://www.rdesktop.org

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

  parent reply	other threads:[~2008-08-16 17:09 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-09 16:26 [PATCH 0/7] Discard requests, v2 David Woodhouse
2008-08-09 16:29 ` [PATCH 1/7] [BLOCK] Fix typo causing compile error in blk_queue_bounce() David Woodhouse
2008-08-09 16:30 ` [PATCH 2/7] [BLOCK] Fix up comments about matching flags between bio and rq David Woodhouse
2008-08-09 16:30 ` [PATCH 3/7] [BLOCK] Add 'discard' request handling David Woodhouse
2008-08-09 20:39   ` OGAWA Hirofumi
2008-08-09 21:37     ` David Woodhouse
2008-08-10  6:32     ` David Woodhouse
2008-08-09 16:31 ` [PATCH 4/7] [FAT] Let the block device know when sectors can be discarded David Woodhouse
2008-08-09 16:32 ` [PATCH 5/7] [MTD] Support 'discard sectors' operation in translation layer support core David Woodhouse
2008-08-09 16:33 ` [PATCH 6/7] [MTD] [FTL] Support 'discard sectors' operation David Woodhouse
2008-08-09 16:33 ` [PATCH 7/7] [BLOCK] Allow elevators to sort/merge discard requests David Woodhouse
2008-10-03 20:29   ` Andrew Morton
2008-10-07 12:07     ` Jens Axboe
2008-08-09 22:48 ` [PATCH 0/7] Discard requests, v2 OGAWA Hirofumi
2008-08-10 10:25   ` David Woodhouse
2008-08-10 16:37     ` Jamie Lokier
2008-08-10 17:55       ` OGAWA Hirofumi
2008-08-10 20:07         ` David Woodhouse
2008-08-10 21:40           ` OGAWA Hirofumi
2008-08-11  9:40             ` David Woodhouse
2008-08-11 10:25               ` OGAWA Hirofumi
2008-08-11 13:17                 ` David Woodhouse
2008-08-11 14:21                   ` OGAWA Hirofumi
2008-08-10 10:29 ` [PATCH 8/7] blktrace: support discard requests David Woodhouse
2008-08-10 10:35   ` [USERSPACE PATCH] " David Woodhouse
2008-08-15  8:43     ` Jens Axboe
2008-08-15  9:01       ` David Woodhouse
2008-08-15  9:08         ` Jens Axboe
2008-08-10 10:41   ` [PATCH 8/7] " David Woodhouse
2008-08-13 11:17     ` Jens Axboe
2008-08-10 11:48 ` [PATCH 9/7] blktrace: simplify flags handling in __blk_add_trace David Woodhouse
2008-08-10 11:50   ` David Woodhouse
2008-08-11 15:11 ` [PATCH 10/7] [BLOCK] Add BLKDISCARD ioctl to allow userspace to discard sectors David Woodhouse
2008-08-11 18:27   ` Matthew Wilcox
2008-08-11 20:52   ` David Woodhouse
2008-08-12  9:14 ` [PATCH 0/7] Discard requests, v2 Jens Axboe
2008-08-12 10:00   ` David Woodhouse
2008-08-12 10:54     ` Jens Axboe
2008-08-12 11:16       ` David Woodhouse
2008-08-12 12:19         ` David Woodhouse
2008-08-12 12:53           ` Jens Axboe
2008-08-12 13:04             ` David Woodhouse
2008-08-12 15:47               ` David Woodhouse
2008-08-12 18:04                 ` Jamie Lokier
2008-08-13 10:22                   ` David Woodhouse
2008-08-13 12:19                     ` Jamie Lokier
2008-08-13 12:26                       ` David Woodhouse
2008-08-13 11:15                 ` Jens Axboe
2008-08-13 11:23                   ` David Woodhouse
2008-08-13 11:32                     ` Jens Axboe
2008-08-13 11:34                       ` David Woodhouse
2008-08-13 12:07                         ` David Woodhouse
2008-08-14  7:49                         ` Jens Axboe
2008-08-14  7:52                           ` David Woodhouse
2008-08-14  7:25                       ` David Woodhouse
2008-08-14  7:33                         ` Stephen Rothwell
2008-08-14  7:37                           ` David Woodhouse
2008-08-14  7:42                           ` Jens Axboe
2008-08-14  7:46                             ` Stephen Rothwell
2008-08-12 18:10     ` Jamie Lokier
2008-08-13 10:20       ` David Woodhouse
2008-08-12 11:42   ` Matthew Wilcox
2008-08-12 11:46     ` David Woodhouse
2008-08-12 19:53   ` OGAWA Hirofumi
2008-08-12 20:11     ` OGAWA Hirofumi
2008-08-13 11:39 ` [PATCH 11/7] Kill REQ_TYPE_FLUSH David Woodhouse
2008-08-13 11:58   ` Geert Uytterhoeven
2008-08-13 12:43     ` David Woodhouse
2008-08-13 15:40   ` Jens Axboe
2008-08-13 15:46     ` David Woodhouse
2008-08-16 17:08 ` Pierre Ossman [this message]
2008-08-16 17:11   ` [PATCH 1/2] mmc_block: factor out the mmc request handling Pierre Ossman
2008-08-16 17:12   ` [PATCH 2/2] mmc_block: erase discarded blocks Pierre Ossman
2008-08-16 17:38   ` [PATCH 0/2] MMC discard support (was [PATCH 0/7] Discard requests, v2) David Woodhouse
2008-08-16 17:51     ` Pierre Ossman
2008-08-22  9:24   ` Jens Axboe
2008-08-22  9:45     ` David Woodhouse
2008-08-22 10:50       ` Jens Axboe
2008-08-22 10:58         ` David Woodhouse
2008-08-22 11:11           ` Pierre Ossman
2008-08-22 11:19             ` Jens Axboe
2008-08-22 11:13     ` Pierre Ossman
2008-08-22 11:20       ` Jens Axboe
2008-08-22 14:49         ` OGAWA Hirofumi
2008-08-22 23:02           ` Pierre Ossman
2008-08-22 23:59             ` OGAWA Hirofumi
2008-08-24 11:23               ` Pierre Ossman
2008-08-24 13:39                 ` OGAWA Hirofumi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080816190858.4d150ea1@mjolnir.drzeus.cx \
    --to=drzeus-list@drzeus.cx \
    --cc=axboe@kernel.dk \
    --cc=dwmw2@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).