From: Andreas Dilger <adilger@sun.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Takashi Sato <t-sato@yk.jp.nec.com>,
linux-fsdevel@vger.kernel.org, dm-devel@redhat.com,
viro@ZenIV.linux.org.uk, linux-ext4@vger.kernel.org,
xfs@oss.sgi.com, hch@infradead.org, axboe@kernel.dk,
mtk.manpages@googlemail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] Implement generic freeze feature
Date: Fri, 22 Aug 2008 01:09:58 -0600 [thread overview]
Message-ID: <20080822070958.GU3392@webber.adilger.int> (raw)
In-Reply-To: <20080821125841.a04a706f.akpm@linux-foundation.org>
On Aug 21, 2008 12:58 -0700, Andrew Morton wrote:
> > #define FIGETBSZ _IO(0x00,2) /* get the block size used for bmap */
> > +#define FIFREEZE _IOWR('X', 119, int) /* Freeze */
> > +#define FITHAW _IOWR('X', 120, int) /* Thaw */
>
> FIFREEZE is 119, but a few lines above we have
>
> #define BLKDISCARD _IO(0x12,119)
>
> Should we be using 120 and 121 here?
No, because 'X' != 0x12... The 'X' is used because this ioctl is compatible
with the XFS implementation of this feature.
Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.
next prev parent reply other threads:[~2008-08-22 7:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-18 12:28 [PATCH 1/3] Implement generic freeze feature Takashi Sato
2008-08-21 19:58 ` Andrew Morton
2008-08-22 7:09 ` Andreas Dilger [this message]
2008-08-29 9:36 ` Takashi Sato
2008-08-22 18:14 ` Christoph Hellwig
2008-08-29 9:37 ` Takashi Sato
2008-09-04 16:55 ` Eric Sandeen
2008-09-11 10:58 ` Takashi Sato
-- strict thread matches above, loose matches on Subject: below --
2008-09-08 11:52 Takashi Sato
2008-09-08 17:10 ` Christoph Hellwig
2008-09-11 11:11 ` Takashi Sato
2008-07-22 9:37 Takashi Sato
2008-06-30 12:23 Takashi Sato
2008-07-01 8:08 ` Christoph Hellwig
2008-06-24 6:59 Takashi Sato
2008-06-24 21:48 ` Andrew Morton
2008-06-27 11:33 ` Takashi Sato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080822070958.GU3392@webber.adilger.int \
--to=adilger@sun.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=hch@infradead.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtk.manpages@googlemail.com \
--cc=t-sato@yk.jp.nec.com \
--cc=viro@ZenIV.linux.org.uk \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).