From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pierre Ossman Subject: Re: [PATCH 0/2] MMC discard support (was [PATCH 0/7] Discard requests, v2) Date: Fri, 22 Aug 2008 13:11:47 +0200 Message-ID: <20080822131147.5bf0eaaf@mjolnir.drzeus.cx> References: <1218299181.26926.88.camel@pmac.infradead.org> <20080816190858.4d150ea1@mjolnir.drzeus.cx> <20080822092448.GC20055@kernel.dk> <1219398302.9583.21.camel@pmac.infradead.org> <20080822105039.GG20055@kernel.dk> <1219402696.9583.27.camel@pmac.infradead.org> Mime-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg=PGP-SHA1; boundary="=_freyr.drzeus.cx-29658-1219403517-0001-2" Cc: Jens Axboe , linux-fsdevel@vger.kernel.org To: David Woodhouse Return-path: Received: from server.drzeus.cx ([85.8.24.28]:52882 "EHLO smtp.drzeus.cx" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750861AbYHVLL6 (ORCPT ); Fri, 22 Aug 2008 07:11:58 -0400 In-Reply-To: <1219402696.9583.27.camel@pmac.infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: This is a MIME-formatted message. If you see this text it means that your E-mail software does not support MIME-formatted messages. --=_freyr.drzeus.cx-29658-1219403517-0001-2 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Fri, 22 Aug 2008 11:58:16 +0100 David Woodhouse wrote: > On Fri, 2008-08-22 at 12:50 +0200, Jens Axboe wrote: > > > I suspect we need a separate 'max_discard_sectors' field. > >=20 > > No, that is what max_hw_sectors is for. >=20 > I thought Pierre's problem is that he has _different_ limits for > discards vs. read/writes?=20 >=20 Indeed. max_hw_sectors is _not_ used for "maximum number of sectors" in most cases, but for "maximum number of bytes the device can transfer". The difference between the two is irrelevant for data requests, but is evident here. --=20 -- Pierre Ossman Linux kernel, MMC maintainer http://www.kernel.org rdesktop, core developer http://www.rdesktop.org WARNING: This correspondence is being monitored by the Swedish government. Make sure your server uses encryption for SMTP traffic and consider using PGP for end-to-end encryption. --=_freyr.drzeus.cx-29658-1219403517-0001-2 Content-Type: application/pgp-signature; name="signature.asc" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) iEYEARECAAYFAkiunvgACgkQ7b8eESbyJLiMbQCeKNmKB1s8Gr5aenbga/3F9vqp k20AoIgqF25pVBApf7Bs6Y+6vuR8CMWA =ucOI -----END PGP SIGNATURE----- --=_freyr.drzeus.cx-29658-1219403517-0001-2--