From: "Serge E. Hallyn" <serge@hallyn.com>
To: Kentaro Takeda <takedakn@nttdata.co.jp>
Cc: viro@ZenIV.linux.org.uk, linux-fsdevel@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, miklos@szeredi.hu,
hch@infradead.org, akpm@linux-foundation.org,
Toshiharu Harada <haradats@nttdata.co.jp>
Subject: Re: (repost) Confirmation of methods for calculating requested pathname.
Date: Tue, 2 Sep 2008 08:11:27 -0500 [thread overview]
Message-ID: <20080902131127.GA5951@hallyn.com> (raw)
In-Reply-To: <48BCC1B6.5030901@nttdata.co.jp>
Quoting Kentaro Takeda (takedakn@nttdata.co.jp):
> Al, could you answer the following question?
>
>
> The current Linux kernel is not designed to pass vfsmount parameter
> that is crucial for pathname-based security including AppArmor and
> TOMOYO Linux, to LSM. Though both projects have been proposing
> patches to calculate pathname, none of them have been accepted as
> you know.
>
> To find the reason for NACK, we examined past proposals and the
> threads. And we came to understand that you oppose accessing vfsmount
> inside vfs helper functions. Is our understanding correct?
>
> If our understanding is correct, we would like to propose a new
> method that does not require modifications to vfs helper functions.
> Attached patch is a trial of this method.
>
> vfs helper functions are surrounded by mnt_want_write() and
> mnt_drop_write() pairs which receive "struct vfsmount" parameter
I thought Al and others (Stephen?) had made it clear that the thing to do was
add new lsm hooks there. So whereas inode_permission takes only an inode and
ends up calling security_inode_permission, you would add a
security_path_permission() or somesuch before or after the call to
inode_permission(), where as you've noted the path is available. You're
*close* to doing the right thing by having a helper who is called at the right
place catch the vfsmount, but you refuse to send a patch doing exactly what
has been suggested.
-serge
next prev parent reply other threads:[~2008-09-02 13:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-19 4:19 Confirmation of methods for calculating requested pathname Kentaro Takeda
2008-09-02 4:31 ` (repost) " Kentaro Takeda
2008-09-02 5:06 ` Alexey Dobriyan
2008-09-02 10:12 ` Kentaro Takeda
2008-09-02 6:42 ` Jamie Lokier
2008-09-02 13:11 ` Serge E. Hallyn [this message]
2008-09-02 13:35 ` Tetsuo Handa
2008-09-02 13:37 ` Stephen Smalley
2008-09-02 14:06 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080902131127.GA5951@hallyn.com \
--to=serge@hallyn.com \
--cc=akpm@linux-foundation.org \
--cc=haradats@nttdata.co.jp \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=takedakn@nttdata.co.jp \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).