From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] affs: fix missing unlocks in affs_remove_link Date: Mon, 8 Sep 2008 19:36:12 +0200 Message-ID: <20080908173612.GA19581@lst.de> References: <20080509103529.GA7445@lst.de> <20080521123821.GA23617@lst.de> <20080810234708.GA11156@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org To: Roman Zippel Return-path: Received: from verein.lst.de ([213.95.11.210]:49989 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753472AbYIHRgO (ORCPT ); Mon, 8 Sep 2008 13:36:14 -0400 Content-Disposition: inline In-Reply-To: <20080810234708.GA11156@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: ping^3? On Mon, Aug 11, 2008 at 01:47:08AM +0200, Christoph Hellwig wrote: > ping? > > On Wed, May 21, 2008 at 02:38:21PM +0200, Christoph Hellwig wrote: > > ping? > > > > On Fri, May 09, 2008 at 12:35:29PM +0200, Christoph Hellwig wrote: > > > In two error cases affs_remove_link doesn't call affs_unlock_dir to > > > release the i_hash_lock semaphore. > > > > > > > > > Signed-off-by: Christoph Hellwig > > > > > > Index: linux-2.6/fs/affs/amigaffs.c > > > =================================================================== > > > --- linux-2.6.orig/fs/affs/amigaffs.c 2008-04-29 17:15:30.000000000 +0200 > > > +++ linux-2.6/fs/affs/amigaffs.c 2008-04-29 17:16:15.000000000 +0200 > > > @@ -179,14 +179,18 @@ affs_remove_link(struct dentry *dentry) > > > affs_lock_dir(dir); > > > affs_fix_dcache(dentry, link_ino); > > > retval = affs_remove_hash(dir, link_bh); > > > - if (retval) > > > + if (retval) { > > > + affs_unlock_dir(dir); > > > goto done; > > > + } > > > mark_buffer_dirty_inode(link_bh, inode); > > > > > > memcpy(AFFS_TAIL(sb, bh)->name, AFFS_TAIL(sb, link_bh)->name, 32); > > > retval = affs_insert_hash(dir, bh); > > > - if (retval) > > > + if (retval) { > > > + affs_unlock_dir(dir); > > > goto done; > > > + } > > > mark_buffer_dirty_inode(bh, inode); > > > > > > affs_unlock_dir(dir); > > ---end quoted text--- > ---end quoted text--- ---end quoted text---