From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH] udf: add llseek method Date: Mon, 8 Sep 2008 20:35:36 +0200 Message-ID: <20080908183535.GA10778@duck.suse.cz> References: <20080908174417.GB19912@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org To: Christoph Hellwig Return-path: Received: from styx.suse.cz ([82.119.242.94]:43944 "EHLO mail.suse.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751646AbYIHSfh (ORCPT ); Mon, 8 Sep 2008 14:35:37 -0400 Content-Disposition: inline In-Reply-To: <20080908174417.GB19912@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon 08-09-08 19:44:17, Christoph Hellwig wrote: > UDF currently doesn't set a llseek method for regular files, which > means it will fall back to default_llseek. This means no one can seek > beyond 2 Gigabytes on reiserfs, and that there's not protection vs > the i_size updates from writers. Thanks. Merged after fixing typo in the changelog (reiserfs -> udf). Honza > Signed-off-by: Christoph Hellwig > > Index: linux-2.6/fs/udf/file.c > =================================================================== > --- linux-2.6.orig/fs/udf/file.c 2008-09-08 19:43:05.000000000 +0200 > +++ linux-2.6/fs/udf/file.c 2008-09-08 19:43:18.000000000 +0200 > @@ -211,6 +211,7 @@ const struct file_operations udf_file_op > .release = udf_release_file, > .fsync = udf_fsync_file, > .splice_read = generic_file_splice_read, > + .llseek = generic_file_llseek, > }; > > const struct inode_operations udf_file_inode_operations = { -- Jan Kara SUSE Labs, CR