From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 2/4] new helper: d_obtain_alias
Date: Tue, 9 Sep 2008 11:26:31 -0400
Message-ID: <20080909152631.GA29279@infradead.org>
References: <20080811134857.GD21264@lst.de> <E1Kd38P-0001td-DS@pomaz-ex.szeredi.hu>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: hch@lst.de, viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org
To: Miklos Szeredi <miklos@szeredi.hu>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from bombadil.infradead.org ([18.85.46.34]:46973 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753270AbYIIP0j (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 9 Sep 2008 11:26:39 -0400
Content-Disposition: inline
In-Reply-To: <E1Kd38P-0001td-DS@pomaz-ex.szeredi.hu>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, Sep 09, 2008 at 03:19:57PM +0200, Miklos Szeredi wrote:
> > + * and will be casted to the corresponding NULL or IS_ERR dentry.
> > + */
> 
> Mixing NULL with ERR_PTR() seems like a bad idea.  It should be either
> one or the other but not both.

It's how the existing interface works.  I think we should move to only
ERR_PTR returns, but it's not very high on my todo list.