From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 3/3] XFS: Combine the XFS and Linux inodes V2
Date: Sun, 14 Sep 2008 09:31:28 -0400 [thread overview]
Message-ID: <20080914133128.GE14266@infradead.org> (raw)
In-Reply-To: <1221315027-29951-4-git-send-email-david@fromorbit.com>
On Sun, Sep 14, 2008 at 12:10:27AM +1000, Dave Chinner wrote:
> + * we need to provide an empty inode free function to prevent
> + * the generic code from trying to free ouuur combined inode.
^^^^ spelling?
> -
> -STATIC void
> -xfs_fs_inode_init_once(
> - void *vnode)
> + struct inode *inode)
> {
> - inode_init_once((struct inode *)vnode);
> + return;
> }
No need for a no-argument return at the end of the function.
> static inline int xfs_icount(struct xfs_inode *ip)
> {
> - struct inode *inode = VFS_I(ip);
> -
> - if (!inode)
> - return atomic_read(&inode->i_count);
> - return -1;
> + return atomic_read(&VFS_I(ip)->i_count);
> }
At this point we can just kill this helper - there's only one caller
anyway.
> - if (xfs_iflush(ip, sync_mode) == 0) {
> + if (!VN_BAD(VFS_I(ip)) && xfs_iflush(ip, sync_mode) == 0) {
Why don't you switch to is_bad_inode directly instead of fixing this
up in a later patch?
next prev parent reply other threads:[~2008-09-14 13:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-13 14:10 [PATCH 0/3] XFS: Combine Linux and XFS inodes Dave Chinner
2008-09-13 14:10 ` [PATCH 1/3] Inode: Allow external initialisers Dave Chinner
2008-09-13 14:10 ` [PATCH 2/3] Inode: Allow external list initialisation Dave Chinner
2008-09-13 14:10 ` [PATCH 3/3] XFS: Combine the XFS and Linux inodes V2 Dave Chinner
2008-09-14 13:31 ` Christoph Hellwig [this message]
2008-09-16 4:47 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080914133128.GE14266@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).