From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?B?SsO2cm4=?= Engel <joern@logfs.org>
Subject: Re: [PATCH 02/27] nilfs2: disk format and userland interface
Date: Wed, 17 Sep 2008 16:31:03 +0200
Message-ID: <20080917143103.GC8750@logfs.org>
References: <1221419304-18572-1-git-send-email-konishi.ryusuke@lab.ntt.co.jp> <1221419304-18572-2-git-send-email-konishi.ryusuke@lab.ntt.co.jp> <1221419304-18572-3-git-send-email-konishi.ryusuke@lab.ntt.co.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	Koji Sato <sato.koji@lab.ntt.co.jp>
To: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
Return-path: <linux-kernel-owner+glk-linux-kernel-3=40m.gmane.org-S1755203AbYIQOb0@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <1221419304-18572-3-git-send-email-konishi.ryusuke@lab.ntt.co.jp>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Mon, 15 September 2008 04:07:59 +0900, Ryusuke Konishi wrote:
>
> +struct nilfs_inode {
> +	__le64	i_blocks;
> +	__le64	i_size;
> +	__le64	i_ctime;
> +	__le64	i_mtime;
> +	__le64	i_dtime;
> +	__le32	i_uid;
> +	__le32	i_gid;
> +	__le16	i_mode;
> +	__le16	i_links_count;
> +	__le32	i_flags;
> +	__le64	i_bmap[NILFS_INODE_BMAP_SIZE];
> +#define i_device_code	i_bmap[0]
> +	__le64	i_xattr;
> +	__le32	i_generation;
> +	__le32	i_pad;
> +};

No atime.  Seems familiar. :)

Did you test the filesystem on big endian systems?  It is relatively
easy to miss bugs if conversion isn't actually necessary.

J=C3=B6rn

--=20
When people work hard for you for a pat on the back, you've got
to give them that pat.
-- Robert Heinlein