linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jörn Engel" <joern@logfs.org>
To: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	Seiji Kihara <kihara.seiji@lab.ntt.co.jp>,
	Yoshiji Amagai <amagai.yoshiji@lab.ntt.co.jp>
Subject: Re: [PATCH 25/27] nilfs2: block cache for garbage collection
Date: Wed, 17 Sep 2008 16:41:47 +0200	[thread overview]
Message-ID: <20080917144146.GD8750@logfs.org> (raw)
In-Reply-To: <1221419304-18572-26-git-send-email-konishi.ryusuke@lab.ntt.co.jp>

On Mon, 15 September 2008 04:08:22 +0900, Ryusuke Konishi wrote:
> 
> This adds the cache of on-disk blocks to be moved in garbage
> collection.  The disk blocks are held with dummy inodes (called
> gcinodes), and this file provides lookup function of the dummy inodes,
> and their buffer read function.

Nice explanation.  Can you add it to the comment header at the top of
the file?  Unlike the GPL preample, it actually helps non-lawyers. ;)

Using dummy inodes is... unusual.  Why can you not use the actual inodes
those blocks belong to?  Or alternatively a single inode that simply
covers the complete physical device?

Jörn

-- 
All models are wrong. Some models are useful.
-- George Box
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2008-09-17 14:41 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-14 19:07 [PATCH 0/27] nilfs2: continuous snapshotting file system Ryusuke Konishi
2008-09-14 19:07 ` [PATCH 01/27] nilfs2: add document Ryusuke Konishi
2008-09-14 19:07   ` [PATCH 02/27] nilfs2: disk format and userland interface Ryusuke Konishi
2008-09-14 19:08     ` [PATCH 03/27] nilfs2: add inode and other major structures Ryusuke Konishi
2008-09-14 19:08       ` [PATCH 04/27] nilfs2: integrated block mapping Ryusuke Konishi
2008-09-14 19:08         ` [PATCH 05/27] nilfs2: B-tree based " Ryusuke Konishi
2008-09-14 19:08           ` [PATCH 06/27] nilfs2: direct " Ryusuke Konishi
2008-09-14 19:08             ` [PATCH 07/27] nilfs2: B-tree node cache Ryusuke Konishi
2008-09-14 19:08               ` [PATCH 08/27] nilfs2: buffer and page operations Ryusuke Konishi
2008-09-14 19:08                 ` [PATCH 09/27] nilfs2: meta data file Ryusuke Konishi
2008-09-14 19:08                   ` [PATCH 10/27] nilfs2: persistent object allocator Ryusuke Konishi
2008-09-14 19:08                     ` [PATCH 11/27] nilfs2: disk address translator Ryusuke Konishi
2008-09-14 19:08                       ` [PATCH 12/27] nilfs2: inode map file Ryusuke Konishi
2008-09-14 19:08                         ` [PATCH 13/27] nilfs2: checkpoint file Ryusuke Konishi
2008-09-14 19:08                           ` [PATCH 14/27] nilfs2: segment usage file Ryusuke Konishi
2008-09-14 19:08                             ` [PATCH 15/27] nilfs2: inode operations Ryusuke Konishi
2008-09-14 19:08                               ` [PATCH 16/27] nilfs2: file operations Ryusuke Konishi
2008-09-14 19:08                                 ` [PATCH 17/27] nilfs2: directory entry operations Ryusuke Konishi
2008-09-14 19:08                                   ` [PATCH 18/27] nilfs2: pathname operations Ryusuke Konishi
2008-09-14 19:08                                     ` [PATCH 19/27] nilfs2: operations for the_nilfs core object Ryusuke Konishi
2008-09-14 19:08                                       ` [PATCH 20/27] nilfs2: super block operations Ryusuke Konishi
2008-09-14 19:08                                         ` [PATCH 21/27] nilfs2: segment buffer Ryusuke Konishi
2008-09-14 19:08                                           ` [PATCH 22/27] nilfs2: segment constructor Ryusuke Konishi
2008-09-14 19:08                                             ` [PATCH 23/27] nilfs2: recovery functions Ryusuke Konishi
2008-09-14 19:08                                               ` [PATCH 24/27] nilfs2: another dat for garbage collection Ryusuke Konishi
2008-09-14 19:08                                                 ` [PATCH 25/27] nilfs2: block cache " Ryusuke Konishi
2008-09-14 19:08                                                   ` [PATCH 26/27] nilfs2: ioctl operations Ryusuke Konishi
2008-09-14 19:08                                                     ` [PATCH 27/27] nilfs2: update makefile and Kconfig Ryusuke Konishi
2008-09-17 14:41                                                   ` Jörn Engel [this message]
2008-09-17 19:09                                                     ` [PATCH 25/27] nilfs2: block cache for garbage collection Ryusuke Konishi
2008-09-17 22:49                                                       ` Jörn Engel
2008-09-20 10:43                                                         ` Ryusuke Konishi
2008-09-20 11:04                                                           ` Jörn Engel
2008-09-15 18:20                                     ` [PATCH 18/27] nilfs2: pathname operations Pekka Enberg
2008-09-16  5:31                                       ` konishi.ryusuke
2008-09-17 14:31     ` [PATCH 02/27] nilfs2: disk format and userland interface Jörn Engel
2008-09-17 15:51       ` Ryusuke Konishi
2008-09-15  9:54   ` [PATCH 01/27] nilfs2: add document Pavel Machek
2008-09-15 20:10     ` konishi.ryusuke
2008-09-16 13:38       ` Chris Mason
2008-09-17 14:54   ` Jörn Engel
2008-09-17 17:52     ` Ryusuke Konishi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080917144146.GD8750@logfs.org \
    --to=joern@logfs.org \
    --cc=akpm@linux-foundation.org \
    --cc=amagai.yoshiji@lab.ntt.co.jp \
    --cc=kihara.seiji@lab.ntt.co.jp \
    --cc=konishi.ryusuke@lab.ntt.co.jp \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).