From: Theodore Tso <tytso@mit.edu>
To: Christoph Hellwig <hch@infradead.org>
Cc: Andreas Dilger <adilger@sun.com>,
Akira Fujita <a-fujita@rs.jp.nec.com>,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [RFC][PATCH 0/12]ext4: online defrag (ver 0.95)
Date: Wed, 1 Oct 2008 17:20:11 -0400 [thread overview]
Message-ID: <20081001212011.GG10080@mit.edu> (raw)
In-Reply-To: <20081001184545.GA2096@infradead.org>
On Wed, Oct 01, 2008 at 02:45:45PM -0400, Christoph Hellwig wrote:
> On Tue, Sep 30, 2008 at 05:40:54PM -0700, Andreas Dilger wrote:
> > Instead of implementing an EXT4_IOC_FIEMAP_INO ioctl, what we had implemented
> > is an EXT4_IOC_WRAPPER, which takes as arguments the inode number and the
> > ioctl command + original ioctl data. This allows inode ioctls to be called
> > against the filesystem root for arbitrary inodes, and doesn't require new
> > implementation for each ioctl:
>
> Or just provide more generic open by handle functionality. Shouldn't be
> too much of a problem to do it in the VFS by reusing the exportfs code.
>
A while back I had implemented an "open by inode" patch for a friend
who needed it for their startup. I never posted it because (a) even
though it was only optionally enabled via a mount option, if you allow
non-root users to access it, it blows a whole through traditional unix
permissions semantics (i.e., a mode 700 directory no longer protects
files underneath that directory), and (b) I was sure that Al Viro
would consider the hacks that I needed to make it work to be far too
ugly to live. :-)
- Ted
next prev parent reply other threads:[~2008-10-01 21:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-27 7:26 [RFC][PATCH 0/12]ext4: online defrag (ver 0.95) Akira Fujita
2008-09-27 14:49 ` Theodore Tso
2008-09-28 23:46 ` Theodore Tso
2008-10-01 0:40 ` Andreas Dilger
2008-10-01 18:45 ` Christoph Hellwig
2008-10-01 21:20 ` Theodore Tso [this message]
2008-10-02 8:10 ` Andreas Dilger
2008-10-02 8:26 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081001212011.GG10080@mit.edu \
--to=tytso@mit.edu \
--cc=a-fujita@rs.jp.nec.com \
--cc=adilger@sun.com \
--cc=hch@infradead.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).