From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH 01/39] ocfs2: POSIX file locks support Date: Wed, 1 Oct 2008 23:11:44 -0700 Message-ID: <20081001231144.87fa2a0b.akpm@linux-foundation.org> References: <1222293680-15451-1-git-send-email-mfasheh@suse.com> <1222293680-15451-2-git-send-email-mfasheh@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, joel.becker@oracle.com, ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org, mfasheh@suse.com To: Mark Fasheh Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:59780 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752386AbYJBGMK (ORCPT ); Thu, 2 Oct 2008 02:12:10 -0400 In-Reply-To: <1222293680-15451-2-git-send-email-mfasheh@suse.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: > On Wed, 24 Sep 2008 15:00:42 -0700 Mark Fasheh wrote: > +int ocfs2_stack_supports_plocks(void) > +{ > + return !!(active_stack && active_stack->sp_ops->plock); > +} It's pointless doing !! on something which is already 0 or 1.