From: Christoph Hellwig <hch@infradead.org>
To: Andreas Dilger <adilger@sun.com>
Cc: Theodore Tso <tytso@mit.edu>,
Christoph Hellwig <hch@infradead.org>,
Akira Fujita <a-fujita@rs.jp.nec.com>,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [RFC][PATCH 0/12]ext4: online defrag (ver 0.95)
Date: Thu, 2 Oct 2008 04:26:10 -0400 [thread overview]
Message-ID: <20081002082610.GA15597@infradead.org> (raw)
In-Reply-To: <20081002081059.GO3160@webber.adilger.int>
On Thu, Oct 02, 2008 at 01:10:59AM -0700, Andreas Dilger wrote:
> We've been using that patch for a long time now in Lustre, but will soon
> be replacing it with code that calls fh_to_dentry() and just craft fake
> fh to have the filesystem open the inode. That avoids all kinds of hacks
> in place internally.
>
> Definitely the __iopen__ directory should only be allowed for root...
Well, the right way to do it is to actually pass in the FH from
userspace. Open by inode # alone is not enough, you alwasy want the
generation, too. And for some filesystems (e.g. reiserfs) the FH is
more complicated. The interface for it would be two ioctls (or better
syscalls) to generate the FH and convert it back to an FD, and possibly
a third one for readlink by handle.
XFS had these since day 1, but I would neither recommend copying the API
or implementation as they are just messed up badly.
prev parent reply other threads:[~2008-10-02 8:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-27 7:26 [RFC][PATCH 0/12]ext4: online defrag (ver 0.95) Akira Fujita
2008-09-27 14:49 ` Theodore Tso
2008-09-28 23:46 ` Theodore Tso
2008-10-01 0:40 ` Andreas Dilger
2008-10-01 18:45 ` Christoph Hellwig
2008-10-01 21:20 ` Theodore Tso
2008-10-02 8:10 ` Andreas Dilger
2008-10-02 8:26 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081002082610.GA15597@infradead.org \
--to=hch@infradead.org \
--cc=a-fujita@rs.jp.nec.com \
--cc=adilger@sun.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).