From: Jamie Lokier <jamie@shareable.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Theodore Tso <tytso@mit.edu>, jim owens <jowens@hp.com>,
linux-fsdevel@vger.kernel.org, Mark Fasheh <mfasheh@suse.com>,
Michael Kerrisk <mtk.manpages@googlemail.com>,
linux-abi@vger.kernel.org
Subject: Re: [PATCH 1/4] vfs: vfs-level fiemap interface
Date: Tue, 7 Oct 2008 14:00:08 +0100 [thread overview]
Message-ID: <20081007130008.GA3503@shareable.org> (raw)
In-Reply-To: <20081007101207.GA10406@infradead.org>
Christoph Hellwig wrote:
> * FIEMAP_EXTENT_ENCODED
I like this name better, it seems clearer what it means.
> This extent does not consistant of plain filesystem blocks but is
> encoded (e.g. encrypted or compressed) or shared with other data by the
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> filesystem.
^^^^^^^^^^
Shared blocks must not be overwritten to the block device when
unmounted - but they might be safe to *read*, e.g. by LILO.
Shared data is not the only situation where it's unsafe to overwrite
blocks in place but they can be read: anything wich data-dependent
metadata, such as checksums, data version numbers or indexing.
Thus:
FIEMAP_EXTENT_READ_ENCODED
FIEMAP_EXTENT_WRITE_ENCODED
where
#define FIEMAP_EXTENT_ENCODED \
(FIEMAP_EXTENT_READ_ENCODED | FIEMAP_EXTENT_WRITE_ENCODED)
> Except for continuous nitpicking about this flag which could be
> continued in mainline before a release this patch looks good to me.
I agree, if there are remaining nits they can be continued in mainline.
-- Jamie
next prev parent reply other threads:[~2008-10-07 13:00 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-03 21:59 [PATCH 0/4] Updated fiemap patches Theodore Ts'o
2008-10-03 21:59 ` [PATCH 1/4] vfs: vfs-level fiemap interface Theodore Ts'o
2008-10-03 21:59 ` [PATCH 2/4] ocfs2: fiemap support Theodore Ts'o
2008-10-03 21:59 ` [PATCH 3/4] generic block based fiemap implementation Theodore Ts'o
2008-10-03 21:59 ` [PATCH 4/4] Hook ext4 to the vfs fiemap interface Theodore Ts'o
2008-10-06 11:35 ` [PATCH 3/4] generic block based fiemap implementation steve
2008-10-06 21:14 ` Theodore Tso
2008-10-07 8:14 ` steve
2008-10-04 2:12 ` [PATCH 1/4] vfs: vfs-level fiemap interface Theodore Tso
2008-10-06 18:15 ` jim owens
2008-10-06 21:07 ` Theodore Tso
2008-10-07 10:12 ` Christoph Hellwig
2008-10-07 10:56 ` Andreas Dilger
2008-10-07 12:52 ` Theodore Tso
2008-10-07 13:00 ` Jamie Lokier [this message]
2008-10-07 13:02 ` Christoph Hellwig
2008-10-07 13:24 ` Jamie Lokier
2008-10-07 13:28 ` Christoph Hellwig
2008-10-07 15:45 ` Theodore Tso
2008-10-07 16:01 ` jim owens
[not found] ` <48EB87DE.4090607-VXdhtT5mjnY@public.gmane.org>
2008-10-07 18:52 ` Theodore Tso
[not found] ` <20081007185219.GD15929-3s7WtUTddSA@public.gmane.org>
2008-10-07 20:31 ` Christoph Hellwig
2008-10-07 13:48 ` Theodore Tso
2008-10-07 23:43 ` Jamie Lokier
2008-10-09 20:40 ` Andreas Dilger
2008-10-06 13:07 ` steve
-- strict thread matches above, loose matches on Subject: below --
2008-10-09 1:48 PATCH [0/4] Updated**3 fiemap patches Theodore Ts'o
[not found] ` <1223516913-17612-1-git-send-email-tytso-3s7WtUTddSA@public.gmane.org>
2008-10-09 1:48 ` [PATCH 1/4] vfs: vfs-level fiemap interface Theodore Ts'o
2008-10-07 1:06 PATCH [0/4] Updated**2 fiemap patches Theodore Ts'o
2008-10-07 1:06 ` [PATCH 1/4] vfs: vfs-level fiemap interface Theodore Ts'o
[not found] ` <1223341581-13802-2-git-send-email-tytso-3s7WtUTddSA@public.gmane.org>
2008-10-07 1:09 ` Theodore Tso
2008-09-13 18:47 YET ANOTHER resend of the fiemap patches Theodore Ts'o
2008-09-13 18:49 ` [PATCH 1/4] vfs: vfs-level fiemap interface Theodore Ts'o
2008-09-13 21:17 ` Anton Altaparmakov
2008-09-13 21:29 ` Theodore Tso
2008-09-13 21:45 ` Matthew Wilcox
2008-09-13 22:41 ` Theodore Tso
2008-09-13 21:59 ` Anton Altaparmakov
2008-09-14 13:51 ` Christoph Hellwig
2008-09-14 13:48 ` Christoph Hellwig
2008-09-14 17:58 ` Theodore Tso
2008-09-15 14:49 ` Christoph Hellwig
2008-09-15 17:53 ` Mark Fasheh
2008-09-16 6:51 ` Andreas Dilger
2008-09-16 21:31 ` Theodore Tso
2008-09-20 16:47 ` Josef 'Jeff' Sipek
2008-09-29 1:07 ` Theodore Tso
2008-09-29 21:13 ` Mark Fasheh
2008-09-29 22:10 ` Theodore Tso
2008-09-14 13:47 ` Christoph Hellwig
2008-09-14 18:01 ` Theodore Tso
2008-09-14 18:08 ` Christoph Hellwig
2008-09-14 19:58 ` Theodore Tso
2008-09-15 14:47 ` Christoph Hellwig
2008-09-16 6:49 ` Andreas Dilger
2008-09-16 22:03 ` Theodore Tso
2008-09-17 14:18 ` Jörn Engel
2008-09-17 15:02 ` Jamie Lokier
2008-09-17 15:25 ` Theodore Tso
2008-09-19 14:05 ` Chris Mason
2008-09-19 17:38 ` Jamie Lokier
2008-09-20 7:43 ` Dave Chinner
2008-09-20 13:50 ` Chris Mason
[not found] ` <20080920135048.GA15698@think.oraclecorp.com>
2008-09-20 15:36 ` Jamie Lokier
2008-09-20 15:44 ` Christoph Hellwig
2008-06-25 22:18 Mark Fasheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081007130008.GA3503@shareable.org \
--to=jamie@shareable.org \
--cc=hch@infradead.org \
--cc=jowens@hp.com \
--cc=linux-abi@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mfasheh@suse.com \
--cc=mtk.manpages@googlemail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).