From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 1/4] vfs: vfs-level fiemap interface Date: Tue, 7 Oct 2008 09:28:54 -0400 Message-ID: <20081007132854.GA15953@infradead.org> References: <1223071147-27180-1-git-send-email-tytso@mit.edu> <1223071147-27180-2-git-send-email-tytso@mit.edu> <20081004021251.GA29174@mit.edu> <48EA55AC.2060102@hp.com> <20081006210706.GB8139@mit.edu> <20081007101207.GA10406@infradead.org> <20081007130008.GA3503@shareable.org> <20081007130218.GA4316@infradead.org> <20081007132436.GC3503@shareable.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , Theodore Tso , jim owens , linux-fsdevel@vger.kernel.org, Mark Fasheh , Michael Kerrisk , linux-abi@vger.kernel.org To: Jamie Lokier Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:49685 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752915AbYJGN25 (ORCPT ); Tue, 7 Oct 2008 09:28:57 -0400 Content-Disposition: inline In-Reply-To: <20081007132436.GC3503@shareable.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Oct 07, 2008 at 02:24:36PM +0100, Jamie Lokier wrote: > Ok, without getting in the way any more :-) it would be good to > clarify in the description whether !(flags & FIEMAP_EXTENT_ENCODED) > means only reading is allowed, or if it means writing over the data > blocks is safe too. > > Just so that filesystems will know whether to set the flag for blocks > which can be read but not written. This may include tail-merged > blocks. I think writing to a filesystem without fs assistance is always a bad idea. And yes, we should add this to the description.