From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark Fasheh <mfasheh@suse.com>
Subject: Re: [PATCH 11/39] ocfs2: Add extent tree operation for xattr value btrees
Date: Tue, 7 Oct 2008 13:19:27 -0700
Message-ID: <20081007201927.GD26373@wotan.suse.de>
References: <1222293680-15451-1-git-send-email-mfasheh@suse.com> <1222293680-15451-12-git-send-email-mfasheh@suse.com> <20081001231201.ece971cf.akpm@linux-foundation.org>
Reply-To: Mark Fasheh <mfasheh@suse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-kernel@vger.kernel.org, joel.becker@oracle.com,
	ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org,
	tao.ma@oracle.com
To: Andrew Morton <akpm@linux-foundation.org>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mail.suse.de ([195.135.220.2]:38527 "EHLO mx1.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754226AbYJGUT3 (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 7 Oct 2008 16:19:29 -0400
Content-Disposition: inline
In-Reply-To: <20081001231201.ece971cf.akpm@linux-foundation.org>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Wed, Oct 01, 2008 at 11:12:01PM -0700, Andrew Morton wrote:
> > On Wed, 24 Sep 2008 15:00:52 -0700 Mark Fasheh <mfasheh@suse.com> wrote:
> > +	void *private;
> >  };
> >  
> >  static void ocfs2_dinode_set_last_eb_blk(struct ocfs2_extent_tree *et,
> > @@ -136,9 +137,50 @@ static struct ocfs2_extent_tree_operations ocfs2_dinode_et_ops = {
> >  	.sanity_check		= ocfs2_dinode_sanity_check,
> >  };
> >  
> > +static void ocfs2_xattr_value_set_last_eb_blk(struct ocfs2_extent_tree *et,
> > +					      u64 blkno)
> > +{
> > +	struct ocfs2_xattr_value_root *xv =
> > +		(struct ocfs2_xattr_value_root *)et->private;
> 
> unneeded and undesirable cast of void*
> 
> > +	xv->xr_last_eb_blk = cpu_to_le64(blkno);
> > +}
> > +
> > +static u64 ocfs2_xattr_value_get_last_eb_blk(struct ocfs2_extent_tree *et)
> > +{
> > +	struct ocfs2_xattr_value_root *xv =
> > +		(struct ocfs2_xattr_value_root *) et->private;
> 
> many etceteras.

Thanks, luckily though, it seems these got fixed later in the series :)
	--Mark

--
Mark Fasheh