From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [patch] fs: remove prepare_write/commit_write Date: Tue, 21 Oct 2008 14:35:18 -0700 Message-ID: <20081021143518.cc48a382.akpm@linux-foundation.org> References: <20080924234116.GC30307@wotan.suse.de> <20081017173445.GA10293@infradead.org> <1224269128.15582.9.camel@badari-desktop> <20081021062020.GA17785@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: torvalds@linux-foundation.org, hch@infradead.org, linux-fsdevel@vger.kernel.org, pbadari@us.ibm.com To: Nick Piggin Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:44440 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752738AbYJUVfr (ORCPT ); Tue, 21 Oct 2008 17:35:47 -0400 In-Reply-To: <20081021062020.GA17785@wotan.suse.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, 21 Oct 2008 08:20:20 +0200 Nick Piggin wrote: > Nothing uses prepare_write or commit_write. Remove them from the tree > completely. We could withdraw simple_prepare_write() too, I guess. But there's some risk that out-of-tree filesystems might be using it within their write_begin() implementations.