From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [patch] fs: remove prepare_write/commit_write
Date: Tue, 21 Oct 2008 14:45:05 -0700
Message-ID: <20081021144505.ad66aa91.akpm@linux-foundation.org>
References: <20080924234116.GC30307@wotan.suse.de>
	<20081017173445.GA10293@infradead.org>
	<1224269128.15582.9.camel@badari-desktop>
	<20081021062020.GA17785@wotan.suse.de>
	<20081021143518.cc48a382.akpm@linux-foundation.org>
	<20081021213635.GA19677@infradead.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: npiggin@suse.de, torvalds@linux-foundation.org, hch@infradead.org,
	linux-fsdevel@vger.kernel.org, pbadari@us.ibm.com
To: Christoph Hellwig <hch@infradead.org>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from smtp1.linux-foundation.org ([140.211.169.13]:43678 "EHLO
	smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751330AbYJUVpQ (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 21 Oct 2008 17:45:16 -0400
In-Reply-To: <20081021213635.GA19677@infradead.org>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, 21 Oct 2008 17:36:35 -0400
Christoph Hellwig <hch@infradead.org> wrote:

> On Tue, Oct 21, 2008 at 02:35:18PM -0700, Andrew Morton wrote:
> > On Tue, 21 Oct 2008 08:20:20 +0200
> > Nick Piggin <npiggin@suse.de> wrote:
> > 
> > > Nothing uses prepare_write or commit_write. Remove them from the tree
> > > completely.
> > 
> > We could withdraw simple_prepare_write() too, I guess.  But there's
> > some risk that out-of-tree filesystems might be using it within their
> > write_begin() implementations.
> 
> So?  That's their risk for beeing out of tree.  Nuke it.

Obviously, multiple repetition of the reasons why this is a poor idea
didn't sink in, so I won't trouble you with another repetition.