From: Andrew Morton <akpm@linux-foundation.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: hch@infradead.org, npiggin@suse.de,
torvalds@linux-foundation.org, linux-fsdevel@vger.kernel.org,
pbadari@us.ibm.com
Subject: Re: [patch] fs: remove prepare_write/commit_write
Date: Tue, 21 Oct 2008 15:01:35 -0700 [thread overview]
Message-ID: <20081021150135.831eab1b.akpm@linux-foundation.org> (raw)
In-Reply-To: <20081021214929.GA24243@infradead.org>
On Tue, 21 Oct 2008 17:49:29 -0400
Christoph Hellwig <hch@infradead.org> wrote:
> On Tue, Oct 21, 2008 at 02:45:05PM -0700, Andrew Morton wrote:
> > Obviously, multiple repetition of the reasons why this is a poor idea
> > didn't sink in, so I won't trouble you with another repetition.
>
> Sorry, but there's absolutely no point of keeping dead code around for
> out of tree code.
yes, there _are_ reasons. Two of which are:
- we inconvenience the maintainers and the users of that out-of-tree code
- we drive away testers. People who are dependent upon out-of-tree
code cannot test kernel.org kernels. This happens! People have
reported it!
> It just means we keep dead weight around, that we
> can't test and thus won't fix. It's not actually doing a service to
> anyone.
We mark it EXPORT_UNUSED_SYMBOL() in 2.6.28.
We remove it from 2.6.29.
That solves the above problems and nothing could be simpler to do.
next prev parent reply other threads:[~2008-10-21 22:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-24 23:41 [patch] fs: remove prepare_write/commit_write Nick Piggin
2008-09-24 23:48 ` Christoph Hellwig
2008-09-24 23:54 ` Nick Piggin
2008-10-17 17:34 ` Christoph Hellwig
2008-10-17 18:45 ` Badari Pulavarty
2008-10-21 6:20 ` Nick Piggin
2008-10-21 21:35 ` Andrew Morton
2008-10-21 21:36 ` Christoph Hellwig
2008-10-21 21:45 ` Andrew Morton
2008-10-21 21:49 ` Christoph Hellwig
2008-10-21 22:01 ` Andrew Morton [this message]
2008-10-22 9:24 ` Nick Piggin
2008-10-22 0:43 ` Andrew Morton
2008-10-22 11:57 ` Edward Shishkin
2008-11-22 10:14 ` [patch 1/2] reiser4: adjust to the new aops Edward Shishkin
2008-11-27 10:34 ` Nick Piggin
2008-11-27 14:34 ` Edward Shishkin
2008-11-27 14:48 ` Nick Piggin
2008-12-26 23:33 ` [patch 2/2] reiser4: adjust to the new aops fixup Edward Shishkin
2008-10-18 1:57 ` [patch] fs: remove prepare_write/commit_write Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081021150135.831eab1b.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=pbadari@us.ibm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).