From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [patch] fs: remove prepare_write/commit_write Date: Tue, 21 Oct 2008 15:01:35 -0700 Message-ID: <20081021150135.831eab1b.akpm@linux-foundation.org> References: <20080924234116.GC30307@wotan.suse.de> <20081017173445.GA10293@infradead.org> <1224269128.15582.9.camel@badari-desktop> <20081021062020.GA17785@wotan.suse.de> <20081021143518.cc48a382.akpm@linux-foundation.org> <20081021213635.GA19677@infradead.org> <20081021144505.ad66aa91.akpm@linux-foundation.org> <20081021214929.GA24243@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: hch@infradead.org, npiggin@suse.de, torvalds@linux-foundation.org, linux-fsdevel@vger.kernel.org, pbadari@us.ibm.com To: Christoph Hellwig Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:41029 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751993AbYJUWCL (ORCPT ); Tue, 21 Oct 2008 18:02:11 -0400 In-Reply-To: <20081021214929.GA24243@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, 21 Oct 2008 17:49:29 -0400 Christoph Hellwig wrote: > On Tue, Oct 21, 2008 at 02:45:05PM -0700, Andrew Morton wrote: > > Obviously, multiple repetition of the reasons why this is a poor idea > > didn't sink in, so I won't trouble you with another repetition. > > Sorry, but there's absolutely no point of keeping dead code around for > out of tree code. yes, there _are_ reasons. Two of which are: - we inconvenience the maintainers and the users of that out-of-tree code - we drive away testers. People who are dependent upon out-of-tree code cannot test kernel.org kernels. This happens! People have reported it! > It just means we keep dead weight around, that we > can't test and thus won't fix. It's not actually doing a service to > anyone. We mark it EXPORT_UNUSED_SYMBOL() in 2.6.28. We remove it from 2.6.29. That solves the above problems and nothing could be simpler to do.