From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [patch 1/7] mm: write_cache_pages writepage error fix Date: Tue, 21 Oct 2008 15:05:20 -0700 Message-ID: <20081021150520.1422086f.akpm@linux-foundation.org> References: <20081021080947.032757000@suse.de> <20081021081138.768065000@nick.local0.net> <20081021145518.c5516cfe.akpm@linux-foundation.org> <20081021220103.GB26094@parisc-linux.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: npiggin@suse.de, linux-fsdevel@vger.kernel.org To: Matthew Wilcox Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:54258 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752101AbYJUWFy (ORCPT ); Tue, 21 Oct 2008 18:05:54 -0400 In-Reply-To: <20081021220103.GB26094@parisc-linux.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, 21 Oct 2008 16:01:03 -0600 Matthew Wilcox wrote: > On Tue, Oct 21, 2008 at 02:55:18PM -0700, Andrew Morton wrote: > > @@ -916,8 +915,8 @@ retry: > ^^^^^^ > Hey, look everyone, our tools are completely shit. yeah, that drive3s me nuts. > > } > > > > if (!wbc->range_cyclic && page->index > end) { > > - done = 1; > > unlock_page(page); > > + goto bale; > > I think you mean "bail". Unless you mean making hay, or the 1913 > Webster definition: > 1. Misery; calamity; misfortune; sorrow. > which would be kind of appropriate, but I think you mean bail out. Then "bail" means "making hey".