From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [patch] fs: remove prepare_write/commit_write Date: Tue, 21 Oct 2008 17:36:35 -0400 Message-ID: <20081021213635.GA19677@infradead.org> References: <20080924234116.GC30307@wotan.suse.de> <20081017173445.GA10293@infradead.org> <1224269128.15582.9.camel@badari-desktop> <20081021062020.GA17785@wotan.suse.de> <20081021143518.cc48a382.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Nick Piggin , torvalds@linux-foundation.org, hch@infradead.org, linux-fsdevel@vger.kernel.org, pbadari@us.ibm.com To: Andrew Morton Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:53085 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752265AbYJUVgi (ORCPT ); Tue, 21 Oct 2008 17:36:38 -0400 Content-Disposition: inline In-Reply-To: <20081021143518.cc48a382.akpm@linux-foundation.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Oct 21, 2008 at 02:35:18PM -0700, Andrew Morton wrote: > On Tue, 21 Oct 2008 08:20:20 +0200 > Nick Piggin wrote: > > > Nothing uses prepare_write or commit_write. Remove them from the tree > > completely. > > We could withdraw simple_prepare_write() too, I guess. But there's > some risk that out-of-tree filesystems might be using it within their > write_begin() implementations. So? That's their risk for beeing out of tree. Nuke it.