From: Matthew Wilcox <matthew@wil.cx>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: npiggin@suse.de, linux-fsdevel@vger.kernel.org
Subject: Re: [patch 1/7] mm: write_cache_pages writepage error fix
Date: Tue, 21 Oct 2008 16:01:03 -0600 [thread overview]
Message-ID: <20081021220103.GB26094@parisc-linux.org> (raw)
In-Reply-To: <20081021145518.c5516cfe.akpm@linux-foundation.org>
On Tue, Oct 21, 2008 at 02:55:18PM -0700, Andrew Morton wrote:
> @@ -916,8 +915,8 @@ retry:
^^^^^^
Hey, look everyone, our tools are completely shit.
> }
>
> if (!wbc->range_cyclic && page->index > end) {
> - done = 1;
> unlock_page(page);
> + goto bale;
I think you mean "bail". Unless you mean making hay, or the 1913
Webster definition:
1. Misery; calamity; misfortune; sorrow.
which would be kind of appropriate, but I think you mean bail out.
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2008-10-21 22:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-21 8:09 [patch 0/7] writeback data integrity and other fixes npiggin
2008-10-21 8:09 ` [patch 1/7] mm: write_cache_pages writepage error fix npiggin
2008-10-21 21:55 ` Andrew Morton
2008-10-21 22:01 ` Matthew Wilcox [this message]
2008-10-21 22:05 ` Andrew Morton
2008-10-22 9:36 ` Nick Piggin
2008-10-22 16:37 ` Andrew Morton
2008-10-28 13:18 ` Nick Piggin
2008-10-21 8:09 ` [patch 2/7] mm: write_cache_pages integrity fix npiggin
2008-10-21 8:09 ` [patch 3/7] mm: do_sync_mapping_range " npiggin
2008-10-21 8:09 ` [patch 4/7] mm: write_cache_pages cyclic fix npiggin
2008-10-21 8:09 ` [patch 5/7] mm: write_cache_pages cleanups npiggin
2008-10-21 8:09 ` [patch 6/7] mm: write_cache_pages optimise page cleaning npiggin
2008-10-21 8:09 ` [patch 7/7] mm: write_cache_pages terminate quickly npiggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081021220103.GB26094@parisc-linux.org \
--to=matthew@wil.cx \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).