From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Subject: Re: [patch 1/7] mm: write_cache_pages writepage error fix Date: Tue, 21 Oct 2008 16:01:03 -0600 Message-ID: <20081021220103.GB26094@parisc-linux.org> References: <20081021080947.032757000@suse.de> <20081021081138.768065000@nick.local0.net> <20081021145518.c5516cfe.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: npiggin@suse.de, linux-fsdevel@vger.kernel.org To: Andrew Morton Return-path: Received: from palinux.external.hp.com ([192.25.206.14]:51664 "EHLO mail.parisc-linux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752186AbYJUWBU (ORCPT ); Tue, 21 Oct 2008 18:01:20 -0400 Content-Disposition: inline In-Reply-To: <20081021145518.c5516cfe.akpm@linux-foundation.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Oct 21, 2008 at 02:55:18PM -0700, Andrew Morton wrote: > @@ -916,8 +915,8 @@ retry: ^^^^^^ Hey, look everyone, our tools are completely shit. > } > > if (!wbc->range_cyclic && page->index > end) { > - done = 1; > unlock_page(page); > + goto bale; I think you mean "bail". Unless you mean making hay, or the 1913 Webster definition: 1. Misery; calamity; misfortune; sorrow. which would be kind of appropriate, but I think you mean bail out. -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."