From: Nick Piggin <npiggin@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: torvalds@linux-foundation.org, hch@infradead.org,
linux-fsdevel@vger.kernel.org, pbadari@us.ibm.com
Subject: Re: [patch] fs: remove prepare_write/commit_write
Date: Wed, 22 Oct 2008 11:24:41 +0200 [thread overview]
Message-ID: <20081022092441.GB4359@wotan.suse.de> (raw)
In-Reply-To: <20081021143518.cc48a382.akpm@linux-foundation.org>
On Tue, Oct 21, 2008 at 02:35:18PM -0700, Andrew Morton wrote:
> On Tue, 21 Oct 2008 08:20:20 +0200
> Nick Piggin <npiggin@suse.de> wrote:
>
> > Nothing uses prepare_write or commit_write. Remove them from the tree
> > completely.
>
> We could withdraw simple_prepare_write() too, I guess. But there's
> some risk that out-of-tree filesystems might be using it within their
> write_begin() implementations.
That's true. A number of the helper functions are still write_begin
implemented by calling into prepare_write... Of course, after this patch,
the bare prepare_write functions won't be any use to external modules
anymore. At least the code still gets exercised and no hacks, though.
With the perform_write_2copy stuff, it almost becomes crazy for us to
support given that very few in-kernel users (and now one) ever test it.
Anyway... this has taken long enough that I don't much care exactly how
it gets merged. Whatever you think best.
next prev parent reply other threads:[~2008-10-22 9:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-24 23:41 [patch] fs: remove prepare_write/commit_write Nick Piggin
2008-09-24 23:48 ` Christoph Hellwig
2008-09-24 23:54 ` Nick Piggin
2008-10-17 17:34 ` Christoph Hellwig
2008-10-17 18:45 ` Badari Pulavarty
2008-10-21 6:20 ` Nick Piggin
2008-10-21 21:35 ` Andrew Morton
2008-10-21 21:36 ` Christoph Hellwig
2008-10-21 21:45 ` Andrew Morton
2008-10-21 21:49 ` Christoph Hellwig
2008-10-21 22:01 ` Andrew Morton
2008-10-22 9:24 ` Nick Piggin [this message]
2008-10-22 0:43 ` Andrew Morton
2008-10-22 11:57 ` Edward Shishkin
2008-11-22 10:14 ` [patch 1/2] reiser4: adjust to the new aops Edward Shishkin
2008-11-27 10:34 ` Nick Piggin
2008-11-27 14:34 ` Edward Shishkin
2008-11-27 14:48 ` Nick Piggin
2008-12-26 23:33 ` [patch 2/2] reiser4: adjust to the new aops fixup Edward Shishkin
2008-10-18 1:57 ` [patch] fs: remove prepare_write/commit_write Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081022092441.GB4359@wotan.suse.de \
--to=npiggin@suse.de \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=pbadari@us.ibm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).