From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [patch 1/7] mm: write_cache_pages writepage error fix Date: Wed, 22 Oct 2008 09:37:15 -0700 Message-ID: <20081022093715.4d213d5e.akpm@linux-foundation.org> References: <20081021080947.032757000@suse.de> <20081021081138.768065000@nick.local0.net> <20081021145518.c5516cfe.akpm@linux-foundation.org> <20081022093632.GF4359@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org To: Nick Piggin Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:43126 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753245AbYJVQhV (ORCPT ); Wed, 22 Oct 2008 12:37:21 -0400 In-Reply-To: <20081022093632.GF4359@wotan.suse.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, 22 Oct 2008 11:36:32 +0200 Nick Piggin wrote: > > > wbc->encountered_congestion = 1; > > > > > > -- > > > > I don't think I like the implementation much. > > > > In all cases in that function where we set done=1, we want to bale out > > right now at this page, rather than processing the remaining pages in > > the pagevec. > > > > So it would be better to implement a bit of code which releases the > > pagevec pages and then breaks out of the loop. Then this bug > > automatically gets fixed. > > I had almost exactly that at some point, then I rethought it because it > was a bigger behaviour change than the bugfix-only. > > I thought the !done thing must be just for batching and to process the > pages already looked up in the pagevec. > > I'll need to backport at least some of these to stable -- any chance of > making the change you suggest toward the end of the patchset? That works. > Let me > know if you want a patch or will do one yourself. I couldn't hope to match your level of testing ;)