From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 13/14] quota: Convert union in mem_dqinfo to a pointer
Date: Mon, 27 Oct 2008 22:55:10 -0700
Message-ID: <20081027225510.f1d258d9.akpm@linux-foundation.org>
References: <1225109512852-git-send-email-jack@suse.cz>
	<12251095123763-git-send-email-jack@suse.cz>
	<12251095124166-git-send-email-jack@suse.cz>
	<1225109512758-git-send-email-jack@suse.cz>
	<12251095122803-git-send-email-jack@suse.cz>
	<12251095124165-git-send-email-jack@suse.cz>
	<1225109513735-git-send-email-jack@suse.cz>
	<12251095131095-git-send-email-jack@suse.cz>
	<12251095133646-git-send-email-jack@suse.cz>
	<12251095133281-git-send-email-jack@suse.cz>
	<12251095131431-git-send-email-jack@suse.cz>
	<1225109513299-git-send-email-jack@suse.cz>
	<12251095133700-git-send-email-jack@suse.cz>
	<122510951372-git-send-email-jack@suse.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: linux-fsdevel@vger.kernel.org
To: Jan Kara <jack@suse.cz>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from smtp1.linux-foundation.org ([140.211.169.13]:42366 "EHLO
	smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1752324AbYJ1Fzn (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 28 Oct 2008 01:55:43 -0400
In-Reply-To: <122510951372-git-send-email-jack@suse.cz>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Mon, 27 Oct 2008 13:11:51 +0100 Jan Kara <jack@suse.cz> wrote:

> +		printk(KERN_WARNING "Not enough memory for quota information"
> +				    "structure.\n");

Linus goes apeshit when he catches us doing this (it makes the error
message hard to grep for).  We can fix it this way:

--- a/fs/quota_v2.c~quota-convert-union-in-mem_dqinfo-to-a-pointer-cleanup
+++ a/fs/quota_v2.c
@@ -83,8 +83,8 @@ static int v2_read_file_info(struct supe
 	}
 	info->dqi_priv = kmalloc(sizeof(struct qtree_mem_dqinfo), GFP_NOFS);
 	if (!info->dqi_priv) {
-		printk(KERN_WARNING "Not enough memory for quota information"
-				    "structure.\n");
+		printk(KERN_WARNING
+		       "Not enough memory for quota information structure.\n");
 		return -1;
 	}
 	qinfo = info->dqi_priv;