From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 11/14] quota: Move quotaio_v[12].h from include/linux/
 to fs/
Date: Tue, 28 Oct 2008 15:32:09 -0700
Message-ID: <20081028153209.d66428fe.akpm@linux-foundation.org>
References: <1225109512852-git-send-email-jack@suse.cz>
	<12251095123763-git-send-email-jack@suse.cz>
	<12251095124166-git-send-email-jack@suse.cz>
	<1225109512758-git-send-email-jack@suse.cz>
	<12251095122803-git-send-email-jack@suse.cz>
	<12251095124165-git-send-email-jack@suse.cz>
	<1225109513735-git-send-email-jack@suse.cz>
	<12251095131095-git-send-email-jack@suse.cz>
	<12251095133646-git-send-email-jack@suse.cz>
	<12251095133281-git-send-email-jack@suse.cz>
	<12251095131431-git-send-email-jack@suse.cz>
	<1225109513299-git-send-email-jack@suse.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: linux-fsdevel@vger.kernel.org, jack@suse.cz
To: Jan Kara <jack@suse.cz>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from smtp1.linux-foundation.org ([140.211.169.13]:37061 "EHLO
	smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751521AbYJ1WcO (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 28 Oct 2008 18:32:14 -0400
In-Reply-To: <1225109513299-git-send-email-jack@suse.cz>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Mon, 27 Oct 2008 13:11:49 +0100
Jan Kara <jack@suse.cz> wrote:

> Since these include files are used only by implementation of quota formats,
> there's no need to have them in include/linux/.

akpm2:/usr/src/25> make headers_check
  CHK     include/linux/version.h
make[1]: `scripts/unifdef' is up to date.
make[2]: *** No rule to make target `/usr/src/devel/include/linux/quotaio_v1.h', needed by `/usr/src/devel/usr/include/linux/.install'.  Stop.


If this header really does need to be exported to userspace then should
it not remain in include/linux/?


Meanwhile I'll do this:

--- a/include/linux/Kbuild~quota-move-quotaio_vh-from-include-linux-to-fs-fix
+++ a/include/linux/Kbuild
@@ -134,8 +134,6 @@ header-y += posix_types.h
 header-y += ppdev.h
 header-y += prctl.h
 header-y += qnxtypes.h
-header-y += quotaio_v1.h
-header-y += quotaio_v2.h
 header-y += radeonfb.h
 header-y += raw.h
 header-y += resource.h

so I can compile stuff.


btw, please work out how this build error escaped detection and arrange
for it to not happen in the future?  Thanks.