From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [patch 0/9] writeback data integrity and other fixes (take 3) Date: Wed, 29 Oct 2008 10:14:35 +1100 Message-ID: <20081028231435.GD4985@disturbed> References: <20081028144715.683011000@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, Chris Mason To: npiggin@suse.de Return-path: Received: from ipmail01.adl6.internode.on.net ([203.16.214.146]:31017 "EHLO ipmail01.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750870AbYJ1XOx (ORCPT ); Tue, 28 Oct 2008 19:14:53 -0400 Content-Disposition: inline In-Reply-To: <20081028144715.683011000@suse.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Oct 29, 2008 at 01:47:15AM +1100, npiggin@suse.de wrote: > OK, I'm happier with this patchset now. Note that I've taken your patch > and mangled it a bit at the end of the series. > > This one survives and seems to run OK here, but I'm mainly doing dumb > stress testing with a handful of filesystems, and data-io error injection > testing. There are a lot of combinations of ways this function can operate > and interact obviously, so it would be helpful to get more review. > > Chris, would you possibly have time to run your btrfs tests that are > sensitive to problems in this code? I could provide you a single patch > rollup against mainline if it helps. Nick, after applying the patchset: CC mm/page-writeback.o mm/page-writeback.c: In function write_cache_pages: mm/page-writeback.c:871: warning: wrteback_index may be used uninitialized in this function Looks harmless, but it probably should be cleaned up. Compiler is 'gcc version 4.3.1 (Debian 4.3.1-9)' Cheers, Dave. -- Dave Chinner david@fromorbit.com