From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH 13/14] quota: Convert union in mem_dqinfo to a pointer Date: Wed, 29 Oct 2008 03:40:58 +0100 Message-ID: <20081029024058.GI24732@duck.suse.cz> References: <12251095124165-git-send-email-jack@suse.cz> <1225109513735-git-send-email-jack@suse.cz> <12251095131095-git-send-email-jack@suse.cz> <12251095133646-git-send-email-jack@suse.cz> <12251095133281-git-send-email-jack@suse.cz> <12251095131431-git-send-email-jack@suse.cz> <1225109513299-git-send-email-jack@suse.cz> <12251095133700-git-send-email-jack@suse.cz> <122510951372-git-send-email-jack@suse.cz> <20081027225510.f1d258d9.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jan Kara , linux-fsdevel@vger.kernel.org To: Andrew Morton Return-path: Received: from styx.suse.cz ([82.119.242.94]:47076 "EHLO mail.suse.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753404AbYJ2Ck7 (ORCPT ); Tue, 28 Oct 2008 22:40:59 -0400 Content-Disposition: inline In-Reply-To: <20081027225510.f1d258d9.akpm@linux-foundation.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon 27-10-08 22:55:10, Andrew Morton wrote: > On Mon, 27 Oct 2008 13:11:51 +0100 Jan Kara wrote: > > > + printk(KERN_WARNING "Not enough memory for quota information" > > + "structure.\n"); > > Linus goes apeshit when he catches us doing this (it makes the error > message hard to grep for). We can fix it this way: OK, noted. Thanks. Honza > --- a/fs/quota_v2.c~quota-convert-union-in-mem_dqinfo-to-a-pointer-cleanup > +++ a/fs/quota_v2.c > @@ -83,8 +83,8 @@ static int v2_read_file_info(struct supe > } > info->dqi_priv = kmalloc(sizeof(struct qtree_mem_dqinfo), GFP_NOFS); > if (!info->dqi_priv) { > - printk(KERN_WARNING "Not enough memory for quota information" > - "structure.\n"); > + printk(KERN_WARNING > + "Not enough memory for quota information structure.\n"); > return -1; > } > qinfo = info->dqi_priv; > -- Jan Kara SUSE Labs, CR