Re: [PATCH 11/14] quota: Move quotaio_v[12].h from include/linux/ to fs/

[Jan Kara <jack@suse.cz>]

On Tue 28-10-08 15:32:09, Andrew Morton wrote:
> On Mon, 27 Oct 2008 13:11:49 +0100
> Jan Kara <jack@suse.cz> wrote:
> 
> > Since these include files are used only by implementation of quota formats,
> > there's no need to have them in include/linux/.
> 
> akpm2:/usr/src/25> make headers_check
>   CHK     include/linux/version.h
> make[1]: `scripts/unifdef' is up to date.
> make[2]: *** No rule to make target `/usr/src/devel/include/linux/quotaio_v1.h', needed by `/usr/src/devel/usr/include/linux/.install'.  Stop.
> 
> 
> If this header really does need to be exported to userspace then should
> it not remain in include/linux/?
  I admit I've forgotten about the fact that it won't be exported to
userspace after moving. These files contain definitions of on disk quota
format. Whether we should export this to userspace is a question -
filesystems seem to make the choice "no" lately. Quota tools have their own
definitions anyway so they don't care. I don't know about anybody else who
would care but ... Anybody has any opinion?

> Meanwhile I'll do this:
> 
> --- a/include/linux/Kbuild~quota-move-quotaio_vh-from-include-linux-to-fs-fix
> +++ a/include/linux/Kbuild
> @@ -134,8 +134,6 @@ header-y += posix_types.h
>  header-y += ppdev.h
>  header-y += prctl.h
>  header-y += qnxtypes.h
> -header-y += quotaio_v1.h
> -header-y += quotaio_v2.h
>  header-y += radeonfb.h
>  header-y += raw.h
>  header-y += resource.h
> 
> so I can compile stuff.
> 
> btw, please work out how this build error escaped detection and arrange
> for it to not happen in the future?  Thanks.
  Hmm, I should read SubmitChecklist (and actually do it) more often ;).

								Honza
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR