From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Piggin Subject: Re: [patch 0/9] writeback data integrity and other fixes (take 3) Date: Wed, 29 Oct 2008 10:21:43 +0100 Message-ID: <20081029092143.GA5953@wotan.suse.de> References: <20081028144715.683011000@suse.de> <20081028153953.GB3082@wotan.suse.de> <20081028222746.GB4985@disturbed> <20081029001653.GF15599@wotan.suse.de> <20081029031645.GE4985@disturbed> <20081029091203.GA32545@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: akpm@linux-foundation.org, xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org, Chris Mason To: Christoph Hellwig Return-path: Received: from mx2.suse.de ([195.135.220.15]:60315 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752758AbYJ2JVp (ORCPT ); Wed, 29 Oct 2008 05:21:45 -0400 Content-Disposition: inline In-Reply-To: <20081029091203.GA32545@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Oct 29, 2008 at 05:12:03AM -0400, Christoph Hellwig wrote: > On Wed, Oct 29, 2008 at 02:16:45PM +1100, Dave Chinner wrote: > > Yeah, that'd do it. Good catch. I can't believe I recently fixed a > > bug that touched these lines of code without noticing the inversion. > > Sometimes I wonder if we should just conver the entire of XFS to > > return negative errors - mistakes in handling negative error numbers > > in the core XFS code happen all the time. > > > > FWIW, the core issue here is that we've got to do the > > filemap_fdatawait() call in the ->fsync method because ->fsync > > gets called before we've waited for the data I/O to complete. > > XFS updates inode state on I/O completion, so we *must* wait > > for data I/O to complete before logging the inode changes. I > > think btrfs has the same problem.... > > Yes. I have patches to fix this by changing what ->fsync does and > how it's called. I really need to get them out on the list. Please do.