From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [patch 0/9] writeback data integrity and other fixes (take 3) Date: Thu, 30 Oct 2008 08:42:02 +1100 Message-ID: <20081029214202.GH17077@disturbed> References: <20081028144715.683011000@suse.de> <20081028153953.GB3082@wotan.suse.de> <20081028222746.GB4985@disturbed> <20081029001653.GF15599@wotan.suse.de> <20081029031645.GE4985@disturbed> <20081029032601.GF4985@disturbed> <20081029091326.GB32545@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Nick Piggin , akpm@linux-foundation.org, xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org, Chris Mason To: Christoph Hellwig Return-path: Received: from ipmail04.adl2.internode.on.net ([203.16.214.57]:54639 "EHLO ipmail04.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753530AbYJ2VmH (ORCPT ); Wed, 29 Oct 2008 17:42:07 -0400 Content-Disposition: inline In-Reply-To: <20081029091326.GB32545@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Oct 29, 2008 at 05:13:26AM -0400, Christoph Hellwig wrote: > On Wed, Oct 29, 2008 at 02:26:01PM +1100, Dave Chinner wrote: > > Ok, I was right - these problems happen all the time. The above call > > should really call xfs_flush_pages() to do the flush and wait. I > > note that xfs_flush_pages() returns negative errors, and all the > > callers expect positive errors. I bet the same occurs for > > xfs_flushinval_pages() and xfs_tosspages() which are the wrappers > > that core XFS code is supposed to be using for flushing and > > invalidating file ranges.... > > > > I'll write up a patch that covers all of these. > > Can you also merge xfs_fsync into xfs_file_fsync while you're at it? > The split newer made any sense as xfs_fsync is as Linux-specific as it > gets and shouldn't be in the pseudo OS-independent layer. I'll do that as a separate patch - it's not really part of a "fix error value inversion" bug fix.... Cheers, Dave. -- Dave Chinner david@fromorbit.com